QA: Add wallet_implicitsegwit to test the ability to transform keys between address types #15888

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:test_wallet_implicitsegwit changing 2 files +65 −0

luke-jr commented at 7:48 AM on April 25, 2019: member

This makes sure the wallet recognises payments to keys via address types they weren't created with.

While we don't want this behaviour, it might make sense to explicitly test that it works until we remove it.
fanquake added the label Tests on Apr 25, 2019

in test/functional/wallet_implicitsegwit.py:7 in 52b02f043a outdated

   0 | @@ -0,0 +1,64 @@
   1 | +#!/usr/bin/env python3
   2 | +# Copyright (c) 2019 The Bitcoin Core developers
   3 | +# Distributed under the MIT software license, see the accompanying
   4 | +# file COPYING or http://www.opensource.org/licenses/mit-license.php.
   5 | +"""Test the wallet implicit segwit feature."""
   6 | +
   7 | +import time

MarcoFalke commented at 12:30 PM on April 25, 2019:

./test/functional/wallet_implicitsegwit.py:7:1: F401 'time' imported but unused
./test/functional/wallet_implicitsegwit.py:11:1: F401 'test_framework.util.assert_equal' imported but unused
./test/functional/wallet_implicitsegwit.py:11:1: F401 'test_framework.util.assert_raises_rpc_error' imported but unused

in test/functional/wallet_implicitsegwit.py:59 in 52b02f043a outdated
```
  54 | +        self.sync_all()
  55 | +
  56 | +        check_implicit_transactions(implicit_keys, self.nodes[0])
  57 | +
  58 | +        self.restart_node(0)
  59 | +        self.restart_node(1)
```
MarcoFalke commented at 12:30 PM on April 25, 2019:

Should add a comment why the restart is needed

luke-jr commented at 9:00 PM on April 25, 2019:

It's literally just testing that things don't change after a restart, but ok...
luke-jr force-pushed on Apr 25, 2019
DrahtBot commented at 11:51 AM on May 13, 2019: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
DrahtBot added the label Needs rebase on Jul 27, 2019
MarcoFalke commented at 1:41 PM on October 12, 2019: member

Fine with me. Needs rebase
QA: Add wallet_implicitsegwit to test the ability to transform keys between address types a6f6f77a86
luke-jr force-pushed on Oct 30, 2019
adamjonas commented at 7:58 PM on October 30, 2019: member

utACK a6f6f77a86a50de32275f7aac37aa6eaf79f79eb
DrahtBot removed the label Needs rebase on Oct 30, 2019
MarcoFalke referenced this in commit 6a7c40bee4 on Nov 1, 2019
MarcoFalke merged this on Nov 1, 2019
MarcoFalke closed this on Nov 1, 2019
sidhujag referenced this in commit 96c37a86e8 on Nov 2, 2019
sidhujag referenced this in commit 2a5f53fcab on Nov 10, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

QA: Add wallet_implicitsegwit to test the ability to transform keys between address types #15888

Conflicts