Unifiy network activity status and 'connect' command line option

anddam commented at 3:06 pm on April 26, 2019: contributor

When starting bitcoin-qt with -noconnect or equivalently -connect-0, I expected the network activity icon in bottom right of the main windows to be in the Network activity disabled, with the X icon.

The network activity indicator has its active icon instead, while correctly reporting 0 active connections to Bitcoin network.

I can always reproduce the issue.

Installed Bitcoin Core is version 0.17.1.0-gef70f9b52b851c7997a9f1a0834714e3eebc1fd8 (64-bit) from http://ppa.launchpad.net/bitcoin/bitcoin/ubuntu PPA.

The operating system is elementary OS 5.0 on a Intel(R) Core(TM) i5-6200U, disk type is a SSD SATA2.

The network enabled status should be unified with the connect command line parameter.

Since the latter is not a boolean flag but a list of IP address and considering the behavior of InterpretNegatedOption(), I figure setting the network activity status to false if connect 0 could be enough.

MarcoFalke commented at 4:49 pm on April 26, 2019: member

Does noconnect disable listen?

luke-jr commented at 4:55 pm on April 26, 2019: member

It should. -connect=* (including =0) is supposed to only connect to specified peers.

MarcoFalke commented at 5:02 pm on April 26, 2019: member

Ok, so it seems that this feature request is based on the misunderstanding that those are not equal?

connect: Only manual connections are made (via GUI console or RPC)
network disabled in the GUI: No connections can be made at all

luke-jr commented at 5:36 pm on April 26, 2019: member

AIUI, the request is to make the “network disabled” mode of these equivalent.

So a node with -connect=0 could have networking enabled via GUI.

anddam commented at 5:37 pm on April 27, 2019: contributor

@MarcoFalke

Ok, so it seems that this feature request is based on the misunderstanding that those are not equal?

No, that is well understood but since -connect seems the only argument to prevent network connection from CLI I’m suggesting to at least set network activity according to -connect=0 at start.

I’m suggesting this due to what a -noconnect argument seems to imply. @luke-jr

So a node with -connect=0 could have networking enabled via GUI.

Exactly, the network activity status would stay separated and could be manually switched on by the user.

MarcoFalke commented at 4:00 pm on April 26, 2020: member

The feature request didn’t seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

MarcoFalke closed this on Apr 26, 2020

MarcoFalke commented at 8:53 am on July 9, 2020: member

Implemented in #19473

anddam commented at 1:30 pm on July 9, 2020: contributor

Will check it, thanks!

MarcoFalke locked this on Feb 15, 2022

Unifiy network activity status and ‘connect’ command line option #15900