tests: Use BOOST_CHECK_EQUAL for verbose prints on fail #15942

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1905-testCryptoEqual changing 1 files +6 −3
  1. MarcoFalke commented at 5:17 PM on May 2, 2019: member

    This should print something like:

    test/crypto_tests.cpp(557): error: in "crypto_tests/sha256d64": check str1 == str2 has failed [b185c0ca629130a6f4fbca4d0ac1164dcebb8e97eff941b1c03cdb406f66d70e != b185c0ca629130a6f4fbca4d0ac1164dcebb8e97eff941b1c03cdb406f66d70a]
    
  2. tests: Use BOOST_CHECK_EQUAL for verbose prints on fail fa3a6899e4
  3. MarcoFalke added the label Needs gitian build on May 2, 2019
  4. MarcoFalke added the label Tests on May 2, 2019
  5. laanwj commented at 5:56 PM on May 2, 2019: member

    In my experience, the specfic end-result hash values are quite useless when debugging bugs in SHA256 implementations, just too much mixing of bits

    But not a strong NACK

  6. DrahtBot commented at 6:42 PM on May 2, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15649 (Add ChaCha20Poly1305@Bitcoin AEAD by jonasschnelli)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. MarcoFalke closed this on May 2, 2019

  8. MarcoFalke deleted the branch on May 2, 2019
  9. MarcoFalke removed the label Needs gitian build on May 2, 2019
  10. DrahtBot locked this on Dec 16, 2021
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me