This avoids compiler warning "this statement may fall through" which would be generated if -Wimplicit-fallthrough were enabled.
Trivial: Add explicit [[fallthrough]] to switch statement #15973
pull HenryYoung42 wants to merge 1 commits into bitcoin:master from HenryYoung42:master changing 1 files +2 −0-
HenryYoung42 commented at 2:39 PM on May 7, 2019: none
-
da07d85aba
Trivial: Add explicit [[fallthrough]] to switch statement
This avoids compiler warning "this statement may fall through" which would be generated if -Wimplicit-fallthrough were enabled.
- fanquake added the label Refactoring on May 7, 2019
-
promag commented at 2:44 PM on May 7, 2019: member
This is only available from C++17.
-
HenryYoung42 commented at 2:51 PM on May 7, 2019: none
Ah then that explains why the Bitcoin build is not seeing this warning, whereas a forked project is. I thought perhaps the warning was disabled but did not check first - my bad. Any idea when Bitcoin will move up to C++17 ?
-
promag commented at 2:57 PM on May 7, 2019: member
I don't know, I guess there's no rush.
-
MarcoFalke commented at 3:06 PM on May 7, 2019: member
Yeah, this should be revisited after c++17, which is going to happen after the next major release earliest.
- MarcoFalke closed this on May 7, 2019
- MarcoFalke locked this on Dec 16, 2021
Contributors
Labels