univalue: Drop overloaded members #15975

pull promag wants to merge 2 commits into bitcoin:master from promag:2019-05-drop-univalue-overloads changing 2 files +1 −53

promag commented at 3:38 PM on May 7, 2019: member

Since UniValue constructors aren't marked explicit then these overloaded auxiliary members are unnecessary. This change also avoids some unnecessary UniValue copies.

Related to #15974.
refactor: Explicitly convert atomic<int> to int 18834276f0
univalue: Drop overloaded members a844dbed0f
luke-jr commented at 3:39 PM on May 7, 2019: member

NACK modifying UniValue here. Change it upstream or not at all, please.
promag commented at 3:50 PM on May 7, 2019: member

@luke-jr I know and will do (I've prefixed with univalue: because of that). I'm just submitting this because of the required changes here.
luke-jr commented at 3:57 PM on May 7, 2019: member

The fact that it requires changes to our code would imply the overloaded members aren't actually unnecessary...?
DrahtBot added the label RPC/REST/ZMQ on May 7, 2019
laanwj commented at 3:06 PM on June 6, 2019: member

I don't think this makes sense, sorry. If we're not using the overloaded methods doesn't mean other clients of univalue don't, so that's not enough reason to remove them.
laanwj closed this on Jun 6, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels