GuessVerificationProgress not locking cs_main as expected #15994

1. 
   jasonbcox commented at 7:22 pm on May 9, 2019: none

   From the comment in GuessVerificationProgress(): //! require cs_main if pindex has not been validated yet (because nChainTx might be unset)

   /interfaces/node.cpp does not have locks on cs_main for the three calls made to GuessVerificationProgress (see getVerificationProgress, handleNotifyBlockTip, handleNotifyHeaderTip).

   I believe there are other calls to GuessVerificationProgress that need similar attention.

2. 
   adamjonas commented at 11:42 am on April 24, 2020: member

   #16426 should close this
3. 
   ariard commented at 9:33 am on May 7, 2020: member

   Yes lock is here now https://github.com/bitcoin/bitcoin/blob/3b1e289248dcda896aaa1c84995ee9c6077601e6/src/interfaces/chain.cpp#L255 ?
4. MarcoFalke closed this on May 7, 2020

   ---

5. DrahtBot locked this on Feb 15, 2022

Contributors
jasonbcox adamjonas ariard