Fixes #15878.
I've also fixed a trivial comment typo in the test file rpc_psbt in this PR.
rpc: use walletrbf as default setting in walletcreatefundedpsbt #16006
pull nalinbhardwaj wants to merge 2 commits into bitcoin:master from nalinbhardwaj:walletcreatefundedpsbt changing 2 files +24 −3-
nalinbhardwaj commented at 1:16 PM on May 10, 2019: none
-
4f681063bd
rpc: use walletrbf as default setting in walletcreatefundedpsbt
Also add tests to verify this behaviour.
-
trivial: Fix comment typo in test/functional/rpc_psbt bf64f87135
- fanquake added the label RPC/REST/ZMQ on May 10, 2019
- MarcoFalke added this to the milestone 0.18.1 on May 10, 2019
- MarcoFalke added the label Needs backport on May 10, 2019
-
DrahtBot commented at 4:27 PM on May 10, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #15911 (Use wallet RBF default for walletcreatefundedpsbt by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
nalinbhardwaj commented at 4:41 PM on May 10, 2019: none
Oh, my bad @Sjors, I didn't realise you had a PR for the issue already. I'll close mine.
Also, for next time, it would be helpful for newcomers like me if you link your PR in the issue page.
- nalinbhardwaj closed this on May 10, 2019
-
MarcoFalke commented at 4:45 PM on May 10, 2019: member
Also, for next time, it would be helpful for newcomers like me if you link your PR in the issue page.
Agree
-
Sjors commented at 12:09 PM on May 12, 2019: member
Oops, done.
- MarcoFalke removed the label Needs backport on May 16, 2019
- MarcoFalke removed this from the milestone 0.18.1 on May 16, 2019
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels