Address labels are sorted case sensitively, should be case insensitive #1601

issue grue0 opened this issue on July 16, 2012
  1. grue0 commented at 5:59 PM on July 16, 2012: none

    Exactly as the title describes. When you sort the "Label" column in "Receive coins", the labels are sorted case sensitively, which means it's (no label)->A->Z->a->z

  2. Diapolo commented at 8:44 PM on July 16, 2012: none

    I'm not sure, if I understand the problem, how would (no label), A, Z, a and z be sorted insensitive ^^?

  3. grue0 commented at 11:32 PM on July 16, 2012: none

    currently, upper case letters are given precedence over lower case letters, which makes no sense, because when sorting from a->z, a label such as "Orange" will come before label "apple", just because it's capitalized. It makes more sense to sort by incasesensitively first, then sort by caps.

  4. Diapolo commented at 5:34 AM on July 17, 2012: none

    I'm not sure if that is even possible, you can sort ascending and descending, which IMHO seems to always prefer uppercase letters.

    <pre> Qt::AscendingOrder: The items are sorted ascending e.g. starts with 'AAA' ends with 'ZZZ' in Latin-1 locales Qt::DescendingOrder: The items are sorted descending e.g. starts with 'ZZZ' ends with 'AAA' in Latin-1 locales </pre>

  5. laanwj commented at 6:34 AM on July 17, 2012: member

    Agreed. Seems we're not the first to need this, there is a property sortCaseSensitivity on the QSortFilterProxyModel:

    http://doc.qt.nokia.com/4.7-snapshot/qsortfilterproxymodel.html#sortCaseSensitivity-prop

  6. laanwj commented at 9:39 AM on July 17, 2012: member

    Please help test #1605

  7. laanwj commented at 6:00 AM on July 18, 2012: member

    Merged

  8. laanwj closed this on Jul 18, 2012

  9. suprnurd referenced this in commit b41d9eac22 on Dec 5, 2017
  10. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me