test: Bump MAX_NODES to 12 #16042

1. 
   MarcoFalke commented at 4:27 pm on May 17, 2019: member

   When testing a combination of settings that affect the datadir (e.g. prune, blockfilter, …) we may need a lot of datadirs. Bump the maximum number of nodes proactively from 8 to 12, so that caches get populated with 12 node dirs, as opposed to 8.

   Also, add an assert that the list of deterministic keys is exactly the number of max nodes (and not more than that.

   Also, create the cache faster.

2. test: Bump MAX_NODES to 12 fa6ad7a5ec
3. DrahtBot added the label Tests on May 17, 2019
4. test: Speed up cache creation fa47330397
5. MarcoFalke force-pushed on May 17, 2019
6. 
   MarcoFalke commented at 5:25 pm on May 17, 2019: member

   Added a commit to create the cache in less than a second.

   Can be tested with time ./test/functional/create_cache.py --cachedir="/tmp/test/cache_$(date)" --tmpdir=/tmp/test/temp

7. 
   DrahtBot commented at 5:43 pm on May 17, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15845 (wallet: Fast rescan with BIP157 block filters by MarcoFalke)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. 
   laanwj commented at 5:39 pm on May 23, 2019: member

   utACK fa473303972b7dad600d949dc9b303d8136cb7e7 I think tests should create as few nodes as they can get away with, but if a test with 12 nodes is useful to get more coverage, then let’s bump this.
9. 
   laanwj commented at 5:40 pm on May 23, 2019: member

   When testing a combination of settings that affect the datadir (e.g. prune, blockfilter, …) we may need a lot of datadirs.

   Oh so these run in serial instead of in parallel? That makes more sense then.

10. MarcoFalke referenced this in commit 63b9efa73d on May 24, 2019
11. MarcoFalke merged this on May 24, 2019
12. MarcoFalke closed this on May 24, 2019

    ---

13. MarcoFalke deleted the branch on May 24, 2019
14. sidhujag referenced this in commit bb9d5fccf0 on May 25, 2019
15. deadalnix referenced this in commit e63d79923b on May 7, 2020
16. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke DrahtBot laanwj

Labels
Tests