Remove global whitelist flags and replace them with per-peer flags #16058

1. 
   MarcoFalke commented at 7:06 pm on May 20, 2019: member

   Global whitelist flags such as -whitelistrelay or -whitelistforcerelay should be removed in favour of per-peer flags -whitelistrelay=$IP_ADDRESS and -whitelistforcerelay=$IP_ADDRESS.

   Otherwise it is not possible to make fine-grained peer-specific settings about whitelisting and it is either “all on” or “all off” for all whitelisted peers.

2. MarcoFalke added the label Brainstorming on May 20, 2019
3. MarcoFalke added the label P2P on May 20, 2019
4. 
   NicolasDorier commented at 6:40 am on June 10, 2019: contributor

   Please do not remove global. Not only this is a breaking change, but very often the global to whitelisted peers is intentional, peer specific is the corner case.
5. 
   MarcoFalke commented at 6:48 am on June 10, 2019: member

   It makes debugging specific peer behaviour hard and unintuitive when you can only turn on or off all of the whitelist features for all peers. For example, you might want to whitelist a peer for bloom filters, but not for transaction relay (https://github.com/bitcoin/bitcoin/pull/16176#issuecomment-500310183).
6. 
   NicolasDorier commented at 7:23 am on June 10, 2019: contributor

   I understand why you want peer specific, but this is not a good argument for removing flags used in the wild. whitebind and whitelist are not counter intuitive and useful as it simplify the configuration.

   Also whitelist is a pain in the ass to use, in docker environment for example, we don’t know beforehand the subnet IP, so whitebind is more useful.

7. MarcoFalke closed this on Oct 2, 2019

   ---

8. MarcoFalke locked this on Dec 16, 2021

Contributors
MarcoFalke NicolasDorier

Labels
Brainstorming P2P