[RPC] sendrawtransaction should not check "mempool min fee not met" #16061

issue NicolasDorier opened this issue on May 21, 2019
  1. NicolasDorier commented at 7:31 AM on May 21, 2019: contributor

    I tried to broadcast one transaction

    Mempool:

    {
      "size": 4168,
      "bytes": 2831662,
      "usage": 9274704,
      "maxmempool": 50000000,
      "mempoolminfee": 0.00003249,
      "minrelaytxfee": 0.00001000
    }
    

    Error:

    mempool min fee not met, 1600 < 2547 (code 66)
    

    Even if my mempool has enough space, a transaction sent through RPC has been rejected.

    While I can understand why such rule apply to transactions coming from P2P, I don't understand why it should apply with transaction coming from sendrawtransaction. (Actually it should also not apply for whitelisted peer imho)

    Such transaction should be, or at least able to pass bypass_limits to true.

    If I get concept ACKs for this, I might do it.

  2. fanquake added the label RPC/REST/ZMQ on May 21, 2019
  3. fanquake added the label Mempool on May 21, 2019
  4. sipa commented at 7:37 AM on May 21, 2019: member

    In general, making RPC acceptance distinct from P2P acceptance means leaking information on transaction origin (as peers can observe a transaction coming from you which you wouldn't have accepted from someone else). Specifically, in this case we announce our min feerate through BIP133, making it obvious when we're violating it ourselves.

  5. NicolasDorier commented at 7:45 AM on May 21, 2019: contributor

    Shit that's good point.

  6. NicolasDorier closed this on May 21, 2019

  7. NicolasDorier commented at 7:46 AM on May 21, 2019: contributor

    Long term solution might be to keep it in the mempool but not broadcasting them until the fee filter goes down.

  8. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me