wallet_balance.py: Prevent edge cases #16079

1. 
   stevenroose commented at 2:39 pm on May 23, 2019: contributor

   I ran into this edge case when running the test on Elements. I had a 0-value output as change.
2. fanquake added the label Tests on May 23, 2019
3. in test/functional/wallet_balance.py:31 in d4755667b3 outdated

   29@@ -30,10 +30,15 @@ def create_transactions(node, address, amt, fees):
   30         ins_total += utxo['amount']
   31         if ins_total + max(fees) > amt:
   

   ---

   ---

   

   MarcoFalke commented at 2:48 pm on May 23, 2019:

   Shouldn’t this also say?

   0        if ins_total >= amt + max(fees):
   

   ---

   

   stevenroose commented at 3:12 pm on May 23, 2019:

   ah yeah I first had that but then rebased on master and noticed that someone already added that max(fees) check. I will edit it to be >= instead.

   ---

   

   stevenroose commented at 3:14 pm on May 23, 2019:

   changed
4. 
   MarcoFalke commented at 2:48 pm on May 23, 2019: member

   ACK, ran into the same issue yesterday. Thanks for fixing before I could
5. stevenroose force-pushed on May 23, 2019
6. wallet_balance.py: Prevent edge cases bb41e632ca
7. MarcoFalke referenced this in commit b4223dd5f1 on May 23, 2019
8. MarcoFalke merged this on May 23, 2019
9. MarcoFalke closed this on May 23, 2019

   ---

10. 
    promag commented at 4:10 pm on May 23, 2019: member

    utACK bb41e63.
11. luke-jr referenced this in commit 25dcf01ac5 on Aug 23, 2019
12. deadalnix referenced this in commit 06b3ec662d on Jun 22, 2020
13. MarcoFalke locked this on Dec 16, 2021

Contributors
stevenroose MarcoFalke promag

Labels
Tests