build/doc: update bitcoin_config.h packages, release process #16080

pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:bitcoin_config-and-release_process-updates changing 2 files +6 −6

jonatack commented at 4:51 PM on May 23, 2019: member
- Bump PACKAGE_VERSION and PACKAGE_STRING in build_msvc/bitcoin_config.h from 0.17 to 0.18 (follow-up to 48ed65b).
- Update doc/release_process.md (follow-up to e47dc4f), new version visible here.
- Perhaps worth backporting the version updates to 0.18.0.
build: bump bitcoin_config.h packages to v0.18
Follow-up to 48ed65b.
3ee28c506d

doc: add bitcoin_config.h PACKAGE updates to release process

and reorganise the section and add relative url links.

Follow-up to e47dc4f.

8afca323e3

fanquake added the label Docs on May 23, 2019
laanwj commented at 6:37 PM on May 23, 2019: member

utACK https://github.com/bitcoin/bitcoin/pull/16080/commits/8afca323e371a7a191d874928046d6bf2fbbe072

Looks like the descriptors were bumped in #15528. I don't think it's necessary to backport release process changes.
MarcoFalke commented at 6:39 PM on May 23, 2019: member

Agree that this doesn't need backport
MarcoFalke merged this on May 23, 2019
MarcoFalke closed this on May 23, 2019
MarcoFalke referenced this in commit fe47ae168b on May 23, 2019
jonatack deleted the branch on May 23, 2019
jonatack commented at 8:45 PM on May 23, 2019: member

Thanks!

I mentioned backporting because in the tagged v0.18.0 release, PACKAGE_VERSION and PACKAGE_STRING in build_msvc/bitcoin_config.h are still set to 0.17 which may (or may not) cause issues for Visual Studio builds (see #11526).
jonatack commented at 8:54 PM on May 23, 2019: member

Appears @sipsorcery agreed to maintain it.
sipsorcery commented at 9:14 PM on May 23, 2019: member

utACK https://github.com/bitcoin/bitcoin/commit/8afca323e371a7a191d874928046d6bf2fbbe072.

Changing the PACKAGE* settings won't cause any problems for the msvc build.

It's not strictly needed to update the build_msvc/bitcoin_config.h as part of the release process since the msvc build is for development/testing purposes only and neither it nor any artifacts produced from it are ever included in any bitcoin core downloads. But it also doesn't hurt and seems reasonable to keep them in sync.
jonatack commented at 9:46 PM on May 23, 2019: member

Thanks @sipsorcery. TIL.
DrahtBot locked this on Dec 16, 2021

Contributors

Labels