Jacekdaa
commented at 4:47 PM on May 27, 2019:
none
Pull requests without a rationale and clear improvement may be closed
immediately.
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly.
Any test improvements or new tests that improve coverage are always welcome.
All other changes should have accompanying unit tests (see src/test/) or
functional tests (see test/). Contributors should note which tests cover
modified code. If no tests exist for a region of modified code, new tests
should accompany the change.
Bug fixes are most welcome when they come with steps to reproduce or an
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
Features are welcome, but might be rejected due to design or scope issues.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of Bitcoin Core, if possible.
Refactoring changes are only accepted if they are required for a feature or
bug fix or otherwise improve developer experience significantly. For example,
most "code style" refactoring changes require a thorough explanation why they
are useful, what downsides they have and why they significantly improve
developer experience or avoid serious programming bugs. Note that code style
is often a subjective matter. Unless they are explicitly mentioned to be
preferred in the developer notes, stylistic code
changes are usually rejected.
Bitcoin Core has a thorough review process and even the most trivial change
needs to pass a lot of eyes and requires non-zero or even substantial time
effort to review. There is a huge lack of active reviewers on the project, so
patches often sit for a long time.
build: bump version to 0.14.0bc69f34b35
qt: pre-rc1 translations updatef68e4414d7
doc: Update release notes from wiki1a02ecc73a
doc: Update manpages for 0.14.0268c390d02
release: bump gitian descriptors for a new 0.14 package cache42f5f21287
Merge #9783: release: bump gitian descriptors for a new 0.14 package cache
42f5f21 release: bump gitian descriptors for a new 0.14 package cache (Cory Fields)
6d61a2b8c5
doc: Add list of authors to release notes
Generated from git, so there may be duplicate authors
if someone used multiple mail addresses.
871e19ac84
Restore removed release notes.1577f0731a
doc: Add changelog for 0.14.0 to release notes6187091411
They're unused and produce nasty deprecation warnings
Github-Pull: #9786
Rebased-From: 3301587dc5c7937141282f3799592d1e398495fb
2afefeade6
[wallet] Remove importmulti always-true check
Remove "nLowestTimestamp <= chainActive.Tip()->GetBlockTimeMax()" check from
importmulti, which is always true because nLowestTimestamp is set to the
minimum of the most recent block time and all the imported key timestamps,
which is necessarily lower than the maximum block time.
Github-Pull: #9760
Rebased-From: ec1267f13b7d0b9b5058c6821cf8dbf74e02d17c
40c754cb38
Bugfix: RPC/Mining: GBT should return 1 MB sizelimit before segwit activates
mempool.dat is a binary file and thus it should be read/written as such.
Fixes #9810.
Github-Pull: #9813
Rebased-From: 171fc91f061d4a980eedfa522e302b8598408cc5
3972a8efb2
Fix typo in release notes.ae1c4e24a6
Fix for issue #9775. Added check for open() returning a NULL pointer.
This turns some compiler warnings into errors. Useful for c-i.
Github-Pull: #9789
Rebased-From: 205830a37b7ffa4f8fa306e5c9eafcee3777fa68
05e906dbc6
build: force a c++ standard to be specified
Newer compilers may switch to newer standards by default. For example, gcc6
uses std=gnu++14 by default.
Github-Pull: #9831
Rebased-From: 9829c54de2725037ee0702306cbaa99fc9aa1826
99fd85cb44
qt: pre-rc2 translations update847e3753a6
doc: Add authors and changes since rc1 to release notes3b2f7fdcae
release: add a few performance-related notes95e68dfe35
Merge #9787: release: add a few performance-related notes
95e68df release: add a few performance-related notes (Cory Fields)
f00429666c
doc: Small release notes fixups in the list of pullsfa230fde64
Merge #9846: doc: Small release notes fixups in the list of pulls
fa230fd doc: Small release notes fixups in the list of pulls (MarcoFalke)
3584902eae
[qa] Make import-rescan.py watchonly check reliable
Send payments during the test from a different node than the node generating
keys to be imported, so the spending node doesn't create transactions that
inadvertently involve (spend funds from) the imported keys.
Fixes #9826
Github-Pull: #9839
Rebased-From: 864890adf5fefcf969f82f70949199b68b36f165
eddaa6b35d
Document increase in memory usage due to mempool/dbcache sharing50ae5c711a
Mention bumpfee in 0.14 release notes.29bae0c6c5
tests: Fix dangling pwalletMain pointer in wallet tests
Merge #9866: Document increase in memory usage due to mempool/dbcache sharing
50ae5c7 Document increase in memory usage due to mempool/dbcache sharing (Matt Corallo)
Tree-SHA512: e52a310a5ac1f94b30f367a7bf514b2cf0724530102953eef7f7c7e00a067db568b5e1b51129dfdb1a237e016c7a8b01cc6da8c06a24ab5b970c43d045adb204
1f83663bc2
Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did).
Fix importmulti returning rescan errors for wrong keys
Bug was a missing ++i line in a new range for loop added in commit e2e2f4c
"Return errors from importmulti if complete rescans are not successful"
Github-Pull: #9829
Rebased-From: 306bd72157f089b962b9c537bbacf710a4158647
ld64 is threaded, and uses a worker for each CPU to parse input files. But
there's a bug in the parser causing dependencies to be calculated differently
based on which files have already been parsed.
As a result, builders with more CPUs are more likely to see non-determinism.
This looks to have been fixed in a newer version of ld64, so just disable
threading for now. There's no noticible slowdown.
Github-Pull: #9891
Rebased-From: 9e4d842afc67c63448cbbe30e5cea906e9c87f7e
Merge #9920: [0.14] Allow any subkey in verify-commits (BlueMatt)
589cd63 Allow any subkey in verify-commits (Matt Corallo)
Tree-SHA512: e3175273c648ed2d990ac931efae5e4bf3bd5ddce7b591f5e64a6831f3c029b252bc5d241dd8d3874467747c3ded87aa1fa334ff53d940cde32c22e584a2c4d0
ccf5e43ce0
Fix regsig checking for subkey sigs in verify-commits
Don't require segwit in getblocktemplate for segwit signalling or mining
Segwit's version bit will be signalled for all invocations of CreateNewBlock,
and not specifying segwit only will cause CreateNewBlock to skip transactions
with witness from being selected.
Github-Pull: #9955
Rebased-From: abe7b3d3abe10e3554b770f40824174b3b217490
569596cc51
Test transaction selection when gbt called without segwit support
We previously would block waiting for a CSemaphoreGrant in
ThreadOpenAddedConnections, when we did not need to. This would
block as the posts in CConnman shutdown were both to the wrong
semaphore and in the wrong location.
Github-Pull: #9953
Rebased-From: e007b243c4840e44857b5ccf686ed35899e44af0
Merge #10013: Fix shutdown hang with >= 8 -addnodes set (0.14 backport)
4e2502b Add missing braces in semaphore posts in net (Matt Corallo)
d2548a4 Fix shutdown hang with >= 8 -addnodes set (Matt Corallo)
Tree-SHA512: 0b157793a2c7fabbc2ed24f974d206fc01c816189d6b6aa5a61bab562a0034f72b643a19b1e7920061e479fb27eddd4abf1c40e772a9573346b221a08e7e5ed9
fa8c6ddbef
Merge #10006: [0.14 backport] Don't require segwit in getblocktemplate for segwit signalling or mining
2cd2cd5 Test transaction selection when gbt called without segwit support (Suhas Daftuar)
569596c Don't require segwit in getblocktemplate for segwit signalling or mining (Suhas Daftuar)
Tree-SHA512: bf2672287713e5adc7e851791207e17490679f941d0b9ed38467ffede3aa3000d229151b8ae54323fc8037e0a8569b2fd910ec19f034fb85d9142289648793c3
Ensure an item exists on the rpcconsole stack before adding
Ensures that there is an item on the rpcconsole stack before adding something to the current stack so that a segmentation fault does not occur.
Github-Pull: #10060
Rebased-From: 4df76e270caa9d828179cae1c7a8918d6f91ec21
ddc2dd1612
depends: fix zlib build on osx
zlib is sneaky and expects ar to be libtool on darwin.
Github-Pull: #9973
Rebased-From: c62475329e5e4c4c3f9570546e2b843288f48c61
e9611d10b6
Optimize GetWitnessHash() for non-segwit transactions
The number of arguments is not checked MutateTxAddOutAddr(..), meaning
that
> ./bitcoin-tx -create outaddr=
accessed the vStrInputParts vector beyond its bounds.
This also includes work by jnewbery to check the inputs for
MutateTxAddPubKey()
Github-Pull: #10130
Rebased-From: eb66bf9bdd5ae20c546314eb2c494ac09929970f
util: Work around (virtual) memory exhaustion on 32-bit w/ glibc
glibc-specific: On 32-bit systems set the number of arenas to 1. By
default, since glibc 2.10, the C library will create up to two heap
arenas per core. This is known to cause excessive virtual address space
usage in our usage. Work around it by setting the maximum number of
arenas to 1.
Github-Pull: #10120
Rebased-From: 625488ace5c41ccba1b68323a72588000782f820
e4c9a90fe9
Merge #10127: [0.14 backport] Mining: Prevent slowdown in CreateNewBlock on large mempools
a296c60 Update benchmarking with package statistics (Suhas Daftuar)
10028fb Add benchmarking for CreateNewBlock (Suhas Daftuar)
b5c3440 Mining: return early when block is almost full (Suhas Daftuar)
Tree-SHA512: 7c39d03a778abe00412743958981a1a55d22fc1843c9a3aef7a56506622e6f5d6b8962c586a339b6031e1ee4815d6981351cf527e8fbe5b265824c81d6c7199d
Accidentally removed in 40b556d3742a1f65d67e2d4c760d0b13fe8be5b7
Github-Pull: #10139
Rebased-From: 4b87973c32bcaa5fa7509793e4f0c4f4f981f21b
f15268db3b
Make GetWitnessCommitmentIndex callable on blocks without a coinbase txn.
This isn't actually needed anywhere, but it's less brittle.
Github-Pull: #10146
Rebased-From: ada0caa165905b50db351a56ec124518c922085a
2fea10ad03
Check transaction count early in submitblock.
There is no point in even hashing a submitted block which doesn't have
a coinbase transaction.
This also results in more useful error reporting on corrupted input.
Thanks to rawodb for the bug report.
Github-Pull: #10146
Rebased-From: 4f15ea102d15eb237b63464725508dc509e98819
a44a6a15f9
Make pcoinsTip memory calculations consistent
Since we are more accurately measuring pcoinsTip peak usage at twice the current in dynamic usage, it makes sense to double the default (this will lead to the same effective usage and peak usage as previously).
We should also double the buffer used to avoid flushing if above 90% but still sufficient space remaining.
Github-Pull: #10133
Rebased-From: 5b95a190e8d7059039ce61e808d494dcf89ebb3b
Always leave a reasonable buffer of 50MB for usage from newly connected block (once over 50%) and increase the high water mark buffer to 200MB.
Github-Pull: #10133
Rebased-From: 1b55e07b7a61a9e6c299cf4c40fde80fa715d440
0e5133cb2e
Test prioritisetransaction and ancestor fee state
There is already a similar test for descendant fee state.
Github-Pull: #10144
Rebased-From: ba7dd8bf6f41de647a8df0c4570df6ac20b08e48
d947afc0f7
Bugfix: ancestor modifed fees were incorrect for descendants
If prioritisetransaction was called for a tx with in-mempool
descendants, the modified ancestor fee values for those descendants was
incorrect.
Github-Pull: #10144
Rebased-From: 9bef02e36525d0eed4e2e31678b3ff04bbb0b8cb
ea060c7495
Bump version to 0.14.147d24c85b7
doc: Update release notes for 0.14.1920acbcca8
doc: Remove release note about release notesdf82ea914f
[qa] Fix mempool_packages.py for the 0.14 branch
The backport in d947afc0f7868815dff248ad398c3680def5bf81 of this
test was incorrect due to an api change in prioritisetransaction.
39febb8c6d
Add some more release notes for 0.14.1.
This adds a blurb for the segwit signaling and fixes up the attribution.
226a9cb35d
Merge #10158: Add some more release notes for 0.14.1.
226a9cb Add some more release notes for 0.14.1. (Gregory Maxwell)
Tree-SHA512: ea74ae21f0a15556c877318833b998869a8a7378b40e168f84c80ee6c3433befa68ba52502d4d13ce2e5f14b8ad6b0a4075d67fea603d60ec94698f2a0606f6d
24d74332c2
Merge #10157: [0.14] Fix the mempool_packages.py test
39febb8 [qa] Fix mempool_packages.py for the 0.14 branch (Suhas Daftuar)
Tree-SHA512: 7b5f2627a76d79da5d7c9d30794219a87bec99296d5f74f66b347c7c8914244bfd07f0d48231adda7269678706fd9158b846d710f942b724c8c5748cc4a49c7e
55f641ca19
Mention dbcache memory changes in 0.14.1 release notesb7caa30c48
Merge #10185: [0.14] Mention dbcache memory changes in release notes
This should make occurances of NodeId wrapping essentially impossible for
real-world usage.
Github-Pull: #10176
Rebased-From: c851be4b25905977ca471c42435dc590fd2ff2f5
Bugfix: PrioritiseTransaction updates the mempool tx counter
The mempool's nTransactionsUpdated is used by getblocktemplate
to trigger new invocations of CreateNewBlock().
Github-Pull: #10196
Rebased-From: 909306cde3770ed7019e7b635e24cedbd9de66ce
d28d583820
Clarify importprivkey help text with example of blank label without rescan
Occasionally I waste a lot of time not remembering that the second parameter to importprivkey must be blank if you intend to stop rescan with "false" as the third parameter.
Github-Pull: #10207
Rebased-From: c9e31c36ffacedb85d4d9ce75a92e011a3e7d4b4
Previously if we didn't have any local addresses, GetLocalAddress would return
0.0.0.0 and then we'd swap in a peer's notion of our address in AdvertiseLocal,
but then nServices would never get set.
Github-Pull: #10424
Rebased-From: 307013469f9a3b8f13d3eb9dbeea419a55148493
37a8fc54d4
Fix importwallet edge case rescan bug
Start importwallet rescans at the first block with timestamp greater or equal
to the wallet birthday instead of the last block with timestamp less or equal.
This fixes an edge case bug where importwallet could fail to start the rescan
early enough if there are blocks with decreasing timestamps or multiple blocks
with the same timestamp.
Github-Pull: #10410
Rebased-From: 2a8e35a11d4bd4828631654fc7b8b8fe8f0a2460
321419bc06
Minor fix in build documentation for FreeBSD 11
- Package name is libevent, not libevent2
- Need to use GNU make
Github-Pull: #10245
Rebased-From: 0611bc3439c65e100db98914d18606f623048ba8
44a17f278a
Check interruptNet during dnsseed lookups0aee4a132b
Reduce cs_main locks during modal overlay by adding an atomic cache1e936d7e87
Update the remaining blocks left in modaloverlay at init.9ac40e853c
Declare headers height/time cache mutable, re-set the methods const7da133772d
Set both time/height header caches at the same time222f3775cf
Add missing <atomic> header in clientmodel.h4bc99c3b28
build: remove wonky auto top-level convenience targets
These were meant to help build subdir targets from the top builddir, but cause
infinite recursion when going the other way.
If anyone actually uses these, we can add back specific targets.
3d395d6815
build: fix bitcoin-config.h regeneration after touching build files
This was a long-standing and annoying problem.
If autogen.sh was not manually run after touching configure.ac,
bitcoin-config.h would not be properly regenerated. This causes very subtle
problems when configure appears to enable a new value, but it does not end up
reflected in the build.
ae479bc45b
[Wallet] unset change position when there is no change on exact match18476423fb
Merge #10484: 0.14 Backports
1847642 [Wallet] unset change position when there is no change on exact match (Gregory Sanders)
ae479bc build: fix bitcoin-config.h regeneration after touching build files (Cory Fields)
3d395d6 build: remove wonky auto top-level convenience targets (Cory Fields)
4bc99c3 Add missing <atomic> header in clientmodel.h (Jonas Schnelli)
222f377 Set both time/height header caches at the same time (Jonas Schnelli)
7da1337 Declare headers height/time cache mutable, re-set the methods const (Jonas Schnelli)
9ac40e8 Update the remaining blocks left in modaloverlay at init. (Jonas Schnelli)
1e936d7 Reduce cs_main locks during modal overlay by adding an atomic cache (Jonas Schnelli)
0aee4a1 Check interruptNet during dnsseed lookups (Matt Corallo)
ff3f9a807d
net: only enforce the services required to connect
also once half of all outgoing nodes have our preferred flags, require only
minimal flags from the rest.
Github-Pull: #10441
Rebased-From: b6fbfc228236947eaea5c14dda299f5a01810e92
9e3ad50078
build: bump version to 0.14.24a41de4585
[trivial] Fix a typo (introduced two days ago) in the default fee warning
Update contrib/debian to latest Ubuntu PPA upload.
This:
* Partially reverts 9f68ed6 (which fixed spelling in a changelog,
though generally changelogs should be append-only).
* Disables UPnP support (PPA has not had it for a while, and I
still don't trust miniupnpc, plus it seems uneccessary - its
been a while since we needed to care about Bitcoin-Qt home users
getting their inbound ports auto-mapped).
* Enables ZMQ.
* Forces GUI to Qt4 to fix various issues people have been seeing
on Ubuntu and elsewhere with Qt5.
* Reverts 70899d70b (Bitcoin does not enable "instant payments",
not is transaction management "carried out collectively by the
network", for whatever "transaction management" means, finally
Bitcoin Core is not the only way to use the Bitcoin currency,
as seemingly implied in the description).
Github-Pull: #10328
Rebased-From: 997021986e02f8e59024ffca6437857d9d17f396
The bumpfee() RPC was returning misleading or incorrect error codes
(for example RPC_INVALID_ADDRESS_OR_KEY when the transaction was not
BIP125 replacable). This commit fixes those error codes:
- RPC_INVALID_ADDRESS_OR_KEY if an invalid address was provided:
- Invalid change address given
- RPC_INVALID_PARAMETER if a single (non-address/key) parameter is incorrect
- confTarget and totalFee options should not both be set.
- Invalid confTarget
- Insufficient totalFee (cannot be less than required fee)
- RPC_WALLET_ERROR for any other error
- Transaction has descendants in the wallet
- Transaction has descendants in the mempool
- Transaction has been mined, or is conflicted with a mined transaction
- Transaction is not BIP 125 replaceable
- Transaction has already been bumped
- Transaction contains inputs that don't belong to the wallet
- Transaction has multiple change outputs
- Transaction does not have a change output
- Fee is higher than maxTxFee
- New fee rate is less than the minimum fee rate
- Change output is too small.
This commit also updates the test cases to explicitly test the error code.
Github-Pull: #9853
Rebased-From: 6d07c62322f60eb2702c6654e994fc353bcfcf8c
3ad00b4b32
Return correct error codes in blockchain.cpp.
RPCs in blockchain.cpp were returning misleading or incorrect error
codes (for example getblock() returning RPC_INTERNAL_ERROR when the
block had been pruned). This commit fixes those error codes:
- RPC_INTERNAL_ERROR should not be returned for application-level
errors, only for genuine internal errors such as corrupted data.
- RPC_METHOD_NOT_FOUND should not be returned in response to a
JSON request for an existing method.
Those error codes have been replaced with RPC_MISC_ERROR or
RPC_INVALID_PARAMETER as appropriate.
Github-Pull: #9853
Rebased-From: c1190963b388590dc0a346bf625c7e84f69cee8d
fe51c8924e
Return correct error codes in removeprunedfunds().
The removeprunedfunds() RPC was returning misleading or incorrect error
codes (for example RPC_INTERNAL_ERROR when the transaction was
not found in the wallet). This commit fixes those error codes:
- RPC_INTERNAL_ERROR should not be returned for application-level
errors, only for genuine internal errors such as corrupted data.
This error code has been replaced with RPC_WALLET_ERROR.
This commit also updates the test cases to explicitly test the error code.
Github-Pull: #9853
Rebased-From: 960bc7f778d8dd618e65f1e37ec734e2d4734051
18c109ddb1
Return correct error codes in setban().
The setban() RPC was returning misleading or incorrect error
codes (for example RPC_CLIENT_NODE_ALREADY_ADDED when an invalid IP
address was entered). This commit fixes those error codes:
- RPC_CLIENT_INVALID_IP_OR_SUBNET should be returned if the client
enters an invalid IP address or subnet.
This commit also updates the test cases to explicitly test the error code.
This commit also adds a testcase for trying to setban on an invalid subnet.
Github-Pull: #9853
Rebased-From: a012087667edb35a36f25ae06b42b1644d80e649
4943d7a9fe
Return correct error codes in fundrawtransaction().
The fundrawtransaction() RPC was returning misleading or incorrect error
codes (for example RPC_INTERNAL_ERROR when funding the transaction
failed). This commit fixes those error codes:
- RPC_INTERNAL_ERROR should not be returned for application-level
errors, only for genuine internal errors such as corrupted data.
That error code has been replaced with RPC_WALLET_ERROR.
This commit also updates the test cases to explicitly test the error code.
Github-Pull: #9853
Rebased-From: dab804c18a427901684ebe936b2069a97e04a268
f5efe82a83
Update release notes to include RPC error code changes.
Merge #10234, #10143 (fixes only), and #9853 via branch 'disconnect_ban_fixes-0.14' into 0.14.2_fixese05799a381
Merge #9481 via remote-tracking branch 'jonas/2017/01/fee_warning' into 0.14.2_fixesaca4b6dbcb
Merge #10008 via branch 'fee_warning-0.14' into 0.14.2_fixes77de9bbc57
Merge #9497 via remote-tracking branch 'origin-pull/9497/head' into 0.14.2_fixes1b864c9820
Merge #10328 via branch 'debianppa-0.14' into 0.14.2_fixesa40d69e0b8
Fix some empty vector references
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.
Github-Pull: #10250
Rebased-From: f478d98fe49d3c0c0f2c79b3f8d9dbfc1aafd407
e23cef0c94
[wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call.
Update the steps for updating the hardcoded seed nodes to point to the
new filename on @sipa's server, and add command to decompress it.
Ref: #10163
Github-Pull: #10495
Rebased-From: ac9cd953d91e2448d24851b2f4973c7be8f4c3cd
76f9cf9ac9
[doc] Add hint about getmempoolentry to getrawmempool help.
doc: Fill in details about miniupnp CVE-2017-87987a643511b4
Note preexisting bug in display of fee calculation in coin control60b967ec41
Merge #10588: doc: Note preexisting bug in display of fee calculation in coin control
60b967e Note preexisting bug in display of fee calculation in coin control (Alex Morcos)
Tree-SHA512: 0179654d313ea10b776781617cea744757344d8b4455153540f116978a72aabdc0a3092388b9cfbe8d0348b699943a9e41082ed964e161e4f3017dcd056e77fc
fc61c8322b
Merge #10516: Backports for 0.14.3
ff274d3 [doc] Add hint about getmempoolentry to getrawmempool help. (Karl-Johan Alm)
76f9cf9 contrib: Update location of seeds.txt (Wladimir J. van der Laan)
12adedf Trivial: remove extra character from comment (CryptAxe)
d2ec969 Fixed typo in documentation for merkleblock.h (Mikerah)
3612219 contrib/init/bitcoind.openrcconf: Don't disable wallet by default (Luke Dashjr)
692dbb0 [doc] Minor corrections to osx dependencies (fanquake)
87a21d5 Fix: make CCoinsViewDbCursor::Seek work for missing keys (Pieter Wuille)
28b8b8b [wallet] Securely erase potentially sensitive keys/values (Thomas Snider)
ff13f59 [wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call. (Karl-Johan Alm)
e23cef0 Fix some empty vector references (Pieter Wuille)
6ad45b8 Re-enable upnp support in contrib/debian (Matt Corallo)
e9a0d89 Build with QT5 on Debian-based systems using contrib/debian (Matt Corallo)
2ea0358 Bump minimum boost version in contrib/debian (Matt Corallo)
c94e262 Update contrib/debian to latest Ubuntu PPA upload. (Matt Corallo)
96c7f2c Add CheckQueue Tests (Jeremy Rubin)
e207342 Fix CCheckQueue IsIdle (potential) race condition and remove dangerous constructors. (Jeremy Rubin)
ef810c4 [trivial] Fix a typo (introduced two days ago) in the default fee warning (practicalswift)
7abe7bb Qt/Send: Give fallback fee a reasonable indent (Luke Dashjr)
3e4d7bf Qt/Send: Figure a decent warning colour from theme (Luke Dashjr)
c5adf8f [Qt] Show more significant warning if we fall back to the default fee (Jonas Schnelli)
ee1a60d [tests] update disconnect_ban.py test case to work with listbanned (John Newbery)
d289b56 [net] listbanned RPC and QT should show correct banned subnets (John Newbery)
0422693 [tests] disconnect_ban: remove dependency on urllib (John Newbery)
98bd0c3 [tests] disconnect_ban: use wait_until instead of sleep (John Newbery)
bfd1cf6 [tests] disconnectban test - only use two nodes (John Newbery)
5bc75bb [tests] fix nodehandling.py flake8 warnings (John Newbery)
c25d0a8 Update release notes to include RPC error code changes. (John Newbery)
f5efe82 Return correct error codes in fundrawtransaction(). (John Newbery)
4943d7a Return correct error codes in setban(). (John Newbery)
18c109d Return correct error codes in removeprunedfunds(). (John Newbery)
fe51c89 Return correct error codes in blockchain.cpp. (John Newbery)
3ad00b4 Return correct error codes in bumpfee(). (John Newbery)
71463a7 [qa] Test prioritise_transaction / getblocktemplate interaction (Suhas Daftuar)
d28d583 Bugfix: PrioritiseTransaction updates the mempool tx counter (Suhas Daftuar)
Tree-SHA512: fa3628527c8e176e438de992b9c5815cc2f3c296dbe5d81b592d17a907554e9c6af7eb595e96a2c345de399ba5326c07b4791a91b7b07f89dce0787c85891206
Merge #11296: [0.14] travis: filter out pyenv (Cory Fields)
a4a0adbc7 travis: filter out pyenv (Cory Fields)
Pull request description:
This fixes the travis issues on the 0.14 branch
Tree-SHA512: 302495d9d5eb554e32e6aa3a788416395d8efeaee153dc2ad9425e2762ac83e36a0a5f128d16098147e95d610dd2fbc7aae70e39a11f54ed421abd38693378d5
b9ca77863b
Fix crash bug with duplicate inputs within a transaction
Introduced by #9049
Github-Pull: #14247
Tree-SHA512: 54ccf896e4c816ba8532644affc984a091ed801d8387bb01a836953c9ec4a345359d98fb58dd5f929617afd42bce0cc40293fecf943a1584207c82dd78da0ea5
52965fbaef
build: Bump version to 0.14.3f503ff1ecd
doc: 0.14.3 release notes5138e9e615
doc: update manpages for 0.14.302857b121c
Merge #14279: 0.14.3 release notes, manpage and version bump
02857b121c13b6ffebcf4c83771b34c1124e7bd2 doc: update manpages for 0.14.3 (Sjors Provoost)
5138e9e615d037462096787a36fdc7e812dbf141 doc: 0.14.3 release notes (Sjors Provoost)
f503ff1ecde0c961b520dec2aef148fda00ad06d build: Bump version to 0.14.3 (Sjors Provoost)
Pull request description:
I left a bunch of test and documentation commits out of the release notes.
Tree-SHA512: 978297ad03fe1c384e4ff6d6a75cbdae6b7e2856c1293747c01735fd17ddcaafbf65c4da2acfb203a8b0d556ebcfc76eaccf450ad7296c6c2ea61979c15ab0c2
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-04-22 09:14 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me
