Don't GPG sign intermediate commits with github-merge tool #16130

1. 
   stevenroose commented at 6:19 PM on May 31, 2019: contributor

   When you don't have an unencrypted key and you have git configured to always sign all commits, you have to sign three times instead of one.

2. fanquake added the label Scripts and tools on May 31, 2019
3. Don't GPG sign intermediate commits with github-merge tool a352d2ae5f
4. 
   MarcoFalke commented at 8:17 AM on June 2, 2019: member

   utACK a352d2ae5f5e8a0204d49d66ff458a1505609de3

5. fanquake requested review from laanwj on Jun 3, 2019
6. 
   laanwj commented at 1:45 PM on June 5, 2019: member

   When you don't have an unencrypted key and you have git configured to always sign all commits, you have to sign three times instead of one.

   This is strange. I have my key on a token and never had to sign more than once. Do you have something in your git config that forces signing all commits? I guess making this explicit cannot hurt so utACK anyhow, though, we can't potentially support any possible git configuration.

7. 
   stevenroose commented at 3:18 PM on June 5, 2019: contributor

   Yeah like you quoted, I have git configured to sign all commits. Yeah but it doesn't hurt to be explicit, actually the code comments say "first create unsigned commit" or something and then don't have the no-sign flag.

   [commit]
   	gpgsign = true
   

8. 
   laanwj commented at 10:57 AM on June 6, 2019: member

   Yeah like you quoted, I have git configured to sign all commits.

   Whoops, missed that.

9. laanwj merged this on Jun 6, 2019
10. laanwj closed this on Jun 6, 2019

    ---

11. laanwj referenced this in commit 26a0d07ddb on Jun 6, 2019
12. fanquake referenced this in commit d1a09cfdb2 on Jul 7, 2019
13. PastaPastaPasta referenced this in commit 503f697c12 on Jun 27, 2021
14. PastaPastaPasta referenced this in commit e48ba62100 on Jun 28, 2021
15. PastaPastaPasta referenced this in commit 6f4fd9beca on Jun 29, 2021
16. PastaPastaPasta referenced this in commit 8c6f6ea385 on Jul 1, 2021
17. PastaPastaPasta referenced this in commit 44e011c471 on Jul 1, 2021
18. PastaPastaPasta referenced this in commit 87800e4bcc on Jul 12, 2021
19. DrahtBot locked this on Dec 16, 2021

Review Requested
laanwj