do not use external IPv4 discovery, when -onlynet="IPv6" #1615

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:net_noExtIp_IPv6only changing 1 files +3 −1

Diapolo commented at 10:21 AM on July 20, 2012: none

No description provided.
do not use external IPv4 discovery, when -onlynet="IPv6" a76552ce47

in src/net.cpp:None in cfb47ab0ea outdated

1877 | @@ -1878,7 +1878,9 @@ void static Discover()
1878 |      }
1879 |  #endif
1880 |  
1881 | -    CreateThread(ThreadGetMyExternalIP, NULL);
1882 | +    // Don't use external IPv4 discovery, when -onlynet="IPv6"
1883 | +    if (IsLimited(NET_IPV6))

laanwj commented at 10:53 AM on July 20, 2012:

Shouldn't this be !IsLimited(NET_IPV4) ?

Diapolo commented at 11:21 AM on July 20, 2012:

Sometimes I should think a bit longer and pull a bit slower ^^.

jgarzik commented at 2:50 PM on July 20, 2012: contributor

ACK
gmaxwell referenced this in commit f00ffc6c00 on Jul 25, 2012
gmaxwell merged this on Jul 25, 2012
gmaxwell closed this on Jul 25, 2012
suprnurd referenced this in commit 9707ca5cea on Dec 5, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

jgarzik

Linked (view graph)

#1625 Bitcoin-Qt: exception in CInv::GetCommand() when using -onlynet="IPv6"#8238 [WIP][depends] ZeroMQ 4.1.5 && ZMQ on Windows