omnilayerDevelop88 #16169

09a84e2 Bump version to Omni Core 0.6.0 (dexX7)

Pull request description:

  This pull request updates the version to Omni Core v0.6.0.

Tree-SHA512: 76b8b9c8ba70dfba9d963f6e1f556f92363583c269f595bf19c3b21040b9ba58a34694593fcfe282ce1cb3ddc7181f35715f53965cf3b878f57f390a8f893ad4

938fc53 Add travis_wait to install (Peter Bushnell)
4efc40a grep -c instead of piping to wc (Peter Bushnell)
7e17795 Restore lint whitespace check (Peter Bushnell)
483755d Shellcheck updates to pass default lint-shell checks (Peter Bushnell)
d0460ec Resolve many shellcheck SC1117 warnings (Peter Bushnell)
2e690ff Restore default shebang lint test and update scripts accordingly (Peter Bushnell)
df1906f Make header guards consistent with lint header guard check (Peter Bushnell)
2536fa2 Check includes and lint circular deps (Peter Bushnell)
0f15704 Resolve lint check-rpc-mappings warnings (Peter Bushnell)

Pull request description:

Tree-SHA512: ae68486324c1d54edb1c2af690ca7d1ef22603896c152bb57c0267d5ec9119dc443f1935de78952ba91c1a32b8806ab0d0c198bfa98cf9537233cd73512e838d

230045e Add release notes for Omni Core 0.6.0 (dexX7)

Pull request description:

  This pull request adds the release notes for Omni Core v0.6.0.

Tree-SHA512: 2e1e5286485ecb50ecf0f5399f4c06852a01a332b9a230d01655a829669350aaad6ebe12999043630801e7f5bb45b672f43427f29dcaeeb0451c126549d9d14f

799c332 Set fSuccess true on valid wtxNew (Peter Bushnell)

Pull request description:

Tree-SHA512: 1580fa19f9e638de5f59ea180d3ae1b77cfac43a0b96770904b75468e0c75192a87fca68995e3a93e0bafb3848ab7c7c189243ef71b673736fd466b89744cae9

16a9537 Fix #1011: different transactions getting the same sortKey in FetchWalletOmniTransactions (Maksim Bashov)

Pull request description:

Tree-SHA512: 9b37570629f87b565d16a4a0bf15513ebfab8a9a2e9e39c6d19208f001af35b21d00798d3d58a87a21d0b80fbdf41c7eed2871f09277fe635172869fe25f54e7

1f521c1 Logic update and logging for funded dust edge case (Peter Bushnell)
2e55baf Do not add dust to fee for omni funded TX (Peter Bushnell)
a4f4de0 Only build TX if successful (Peter Bushnell)

Pull request description:

Tree-SHA512: 6111db51a73c9b92bb5f463939b26b01d9cba11dd4c0ecd9f4ce97bc155fd02737efeeb46d909cb69ffdf56ca082797127144ae17f972c9acdc0d62332858218

This reverts commit 7e1779574f53f227c9b4e5af218012e8830d55c7.

1c1488c Revert "Restore lint whitespace check" (Bushstar)

Pull request description:

Tree-SHA512: c40cea97bece30df9052f9b284ca236185c5b220c012b65ea5211d7808bd52ae98c84850fcd30f11a92c36d8c6204879b851e5ec94b19a0bc590ebc751c85ac7

d1af4e0 Fix minutes in "rescan ... remaining" message (Pavel Gulchuk)

Pull request description:

  Fix message like
  ```
  Progress: 75.63 % (about 2:121:57 hours remaining)
  ```

Tree-SHA512: 680f29bc3734eb68aeb71b48d635e5a0c207e3d5a04fdb874cc80f173ab9701dcee19a883a502b90892d49b6de2c796c542dd46b10fbd08072eeaaf698654845

d7caa60 Lock cs_main and cs_tally when calling LoadAlerts (Bushstar)

Pull request description:

Tree-SHA512: a5efb9e830dbe47268c7c444b62505b948cc38de6e9cb4c2d1ecf90d40e08e535e1bb3f27275efe6416d6acc09eaf6584530407da1992cb18fbaf21ab52a2840

4b7e61f Remove additional dust logging (Bushstar)
20c1049 Lock cs_main before calling AcceptToMemoryPool (Bushstar)

Pull request description:

Tree-SHA512: c13ab53fceae954ad4d10d4d85f7851102c6e97863ebc88cf4daecb9a6e577a99166502aa54b022fa2b75825f1f9baa7dfa4a79fd9fc6658eafe17b8bf77b0bc

5a35c60 Fail funded send TXs with more outputs than expected (Bushstar)

Pull request description:

Tree-SHA512: c3847f800c45fb061d5ae526897f5bc24863c05a39b96d1c0f54bcb6bc06e06c8ecf0b0d37d8d00c9d06b8b78f07ed5f5a36a706520fd22e9680c88d8ef73753

2dfc9d8 Set Omni bespoke user agent string (Peter Bushnell)
f607a22 Set Omni bespoke user agent string (Peter Bushnell)

Pull request description:

Tree-SHA512: 25eb33595c5da42cb8d3637c34515d0b3848416ca9d786a91997a4f1f11553ef2385fa76e2003a42e862ce0d6be7bbf7fa0b1daeb927046d5441c5e391df8934

f7d958d Free the DEx and allow other tokens to be traded (dexX7)
1e7bd04 Ensure there can only be one active offer, when creating a new DEx offer (dexX7)
7e34e10 Handle DEx payment based on offer for sale (dexX7)
dceb321 Only check for primary tokens, when DEx is not free yet (dexX7)
eeaa883 When creating DEx orders, parse amount based on token divisibility (dexX7)
f57de0e When creating DEx offer, check there is no other (dexX7)
158250d Add feature activation for freeing the DEx (dexX7)

Pull request description:

  This pull request updates the traditional distributed exchange, where users can trade Omni and Test Omni for Bitcoin.

  When this feature is activated, any token can be traded and it's no longer limited to the two primary native tokens of the Omni Layer protocol.

Tree-SHA512: ea7836279463e9e399ee3a054ee537badc4701d85d30cbd9a0f2608c533e5cd82b07ac8d04fb2cf644cd5d4add60927b4de236e232795104b8e03581363cd50f

dee5240 Update release notes for v0.7.0 (dexX7)
3c6e31b Bump version to 0.7.0 (dexX7)
b006974 Update release notes for 0.6.1 (dexX7)
7a87992 Bump version to 0.6.1 (dexX7)

Pull request description:

  This pull request updates the version and release notes for Omni Core 0.6.1.

Tree-SHA512: 31e9bf163694f7f5890316f798ef66dc228cefdcc0b4c561bbe68cc8ace4ce14c42eb41b4aacb5331cbe06e9949fa88fd25416b3e64c57c681b691de6d2ea468

3f62fd5 omni_senddexaccept pass min fee to CreateTransaction (Peter Bushnell)

Pull request description:

Tree-SHA512: 848aee038f40bb7a72267b686f3439db31d17cf1ccb792ba9f0471b2fbefab0891b9a0f73e09db5ec76f13c0a29c98058fbc948b6c938d87d37eeee9c87b77cb

d6bdff8 Do not include rpctx.cpp if ENABLE_WALLET not defined (Peter Bushnell)
33eb20c Add RPC DEx call to pay for accepted offer (Peter Bushnell)
6273136 Use second part of parsed string for buyer (Peter Bushnell)

Pull request description:

  - Adds RPC DEx call to pay for accepted offer.
  - Fixes offer persistence issue and minor logging error

Tree-SHA512: 696d499edeabd81597dc98c47aecabb6c7091a94b6853e37be8697ce04c3d59fce23d0d9aa394a6b1e37218fd1237bc92f5ca2705681314d4346251636214b5a

1240618 Remove cs_main from eraseMaxedCrowdsale (Peter Bushnell)
eb8a986 Print ErrorAmount if CreatePropertyFixed is invalid (Peter Bushnell)
b122e82 Use removedCoins first if available (Peter Bushnell)
0c4e292 Avoid potential deadlocks (Peter Bushnell)
1f70fb1 tests: Update valgrind suppressions (practicalswift)
97b1abc Add debug to Travis build (Bushstar)

Pull request description:

Tree-SHA512: b600b383ff7b31197a46b7957b68e4678144f9c1374287d40702253e99ddf714cd2f3b67f930bf1466ffcb6a0fd7bfed4d93b5b14c3c197ef2c4e39c2b6e2564

1f3a1b8 Only use wtxNew if fSuccess true (Peter Bushnell)

Pull request description:

Tree-SHA512: 6fc7f165696196c8c81a63fe36d1c7956422c4ad4dd91d513756f2fd8544cd3ecfe51861ab0fa50bf5871152a29f0c8646aa6d5a44534c296b2a8af14629f388

7c2308e Make icons compatible with deterministic build (Peter Bushnell)
5219ded Restore Bitcoin default splash (Peter Bushnell)
656f45e Update icons (Peter Bushnell)

Pull request description:

Tree-SHA512: 9f730ef7015cb02b11121941db49b082c9b5b6e033a8aeabbec9d44f93fdc39bb1c6cf0159e2ac4bfd51490ca647bfd47d34dc006aece4438b99c49db1c4fe0d

4d7dd0c Add release notes for Omni Core 0.7.1 (dexX7)
92cf8e9 Bump version to 0.7.1 and update tests (dexX7)

Pull request description:

  This pull request updates the version of Omni Core 0.7.1 and adds tests for it. It also updates the release notes of this version.

Tree-SHA512: d10edb3ee872caca7a3c307955677ef213e2bd92e22c0a3eae3978c0b1b910f24c0e8e2b2ca9931e6de40aa2434db8e3d99380a926887782bd85f44a04e18d79

ad21db5 Update release notes for v0.7.1 (dexX7)

Pull request description:

  This pull request fixes a link in the release notes and adds a section for the rpcallowip changes.

Tree-SHA512: 5fa69b990084aa3c9e12e4c956db4e5dd68ada5999fe4463bb5f379ccd84c3b48e25222eaef93aa402cb4b71715fe2fe5d5d465c92b8d91e49ab8e0984b53833

86ec33e Move mastercore_handler_block_begin and use chain height (Peter Bushnell)

Pull request description:

Tree-SHA512: 6474679ab1f0f8d23b27bdcb794363f0d5a238851eeda9a37df3ceccd90850ba7fe66ea5c977823e4781a11bc4ba6870fa4dedef183f734c3c78ca9dfce56eb4

During the next startup, Omni Core wipes it's databases and rescans for Omni Layer transactions.

Update the version and version tests from 0.7.1 to 0.8.0

7bbbb5b Bump DB version to force reparse (dexX7)

Pull request description:

  During the next startup, Omni Core wipes it's databases and rescans for Omni Layer transactions.

Tree-SHA512: 0919ffce0ac52205b56ede099b1e11533785f4b2f2ca80ee44b85928b1e44a66cb25593bacdb8cb48012d421e8564c0ad67b7691a940c66d2b04ae2dbc2c6bd7

3e342bd Bump version to 0.8.0 (dexX7)

Pull request description:

  Update the version and version tests from 0.7.1 to 0.8.0

Tree-SHA512: b0333054c9ec68105ca148567be7223d5b8efbc7542464cb35a3256da5872c77116da4103dd4d0c2039eb21142b2e9e45b0440134edd5a963dbd5078efce06f0

670d747 Update release notes for Omni Core 0.8.0 (dexX7)

Pull request description:

  This pull request updates the release notes for Omni Core 0.8.0.

Tree-SHA512: ea0f2c65a1740f769b16edf367f2b551784dc86e1e8a6f4833878e6524153c67c08df4d0c9aa1b7cb1d5fec346e56b4ad41b37f13ad0498d9f9e3faf11cfaca7

77e4022 Avoid MakeWallet() when compiled without wallet (Peter Bushnell)

Pull request description:

  When compiled with --disable-wallet set MakeWallet() should not be called as it will throw an error. Several other RPC calls are removed from compilation when --disable-wallet is set as they are not part of the RPC interface in this configuration.

Tree-SHA512: 0f5695b9cc88b510e61f5e150d31447f057c02e426da466ffdeaa8e9da00520088b4f3fb61c755c058dc1a3f72c32be2776d2024036c0a0de43d2cec12950776

This function calculateDExPurchase() was already included via the header.

The fee cache used for the fee distribution is only needed, when the feature of fee distribution is activated. When this is not the case, it's just a performance burdon, which can easily take 0.3 additional seconds, when a new block is processed.

d01de44 Remove redundant function declaration in test (dexX7)

Pull request description:

  The function calculateDExPurchase() was already included via the header. This causes a warning during the build.

Tree-SHA512: 841a0ae04535b0ebd94114e47ea5406e3cd28e60bf2e4deb603e5fad21ad6669f73f28dd1921a51761a11a08a335796bf4ec4a401d3f06daca425441ba3e35da

3a9e113 Only evaluate fee cache, when it's activated (dexX7)

Pull request description:

  The fee cache used for the fee distribution is only needed, when the feature of fee distribution is activated. When this is not the case, it's just a performance burdon, which can easily take 0.3 additional seconds, when a new block is processed.

Tree-SHA512: 13167bac8df157f2ddfe977b6fb68b1ba69439ce300d98b25c0356277e032ba0f40eb093720efb4e8fec9e2b3406febef98cdb3c8b2f902274106594793e99ec

A major bottle neck during the initial synchronization, rescanning or processing new blocks is due to storing the consensus state to disk.

This is done, so the state can easily be rolled back in case of a block reorganization.

However, during the inital synchronization or when rescanning and reparsing historical blocks, it is only needed in case of a shutdown or crash, but can be skipped otherwise.

Also: store state every 5000 blocks during initial synchronization or rescanning.

063eb8c Don't store state every block, when syncing or rescanning (dexX7)

Pull request description:

  A major bottle neck during the initial synchronization, rescanning or processing new blocks is due to storing the consensus state to disk.

  This is done, so the state can easily be rolled back in case of a block reorganization.

  However, during the inital synchronization or when rescanning and reparsing historical blocks, it is only needed in case of a shutdown or crash, but can be skipped otherwise.

  Also: store state every 5000 blocks during initial synchronization or rescanning.

Tree-SHA512: 48606bcac8549cac82882bcf64465bfa7bdc2a05075a23e89df24d98df0e584250478820918068100f2b69d2e9ee9ac3fb28a745c5309b1b2792d16167fa9d6e

2178072 Bump version to Omni Core 0.8.1 (dexX7)

Pull request description:

  This pull request updates the version of Omni Core to 0.8.1.

Tree-SHA512: 93eac34d2d92f478454ebecac4a569c765be94bc64827d1823a251a42c6359f4bd7adb5c51141467cb6c5ae94b9288fb99d28c698cb63b44f10d9a6d392afbdd

3bb8213 Update release notes for Omni Core 0.8.1 (dexX7)

Pull request description:

  This pull request updates the release notes for Omni Core 0.8.1.

Tree-SHA512: c96f5b6bc5d792004942991f3cb39abc7495524c76049ce75ce2d75cffb6f9e44f1d7b70dbbb40f1915cd154840cdc70cf02609b575b5a6192096883ea087a2b

a9dcb01 doc: set ecosystem as numeric (Peter Bushnell)

Pull request description:

Tree-SHA512: 93a61a4cbd9683b9bc3ead327db12106bf0cf8fea277f31556ab1e908b2515e3384ff0526fc997517835899fb314cf79bbd4dc899644e43d1ca3a325e05ee70b

10bcb05 Fix parsing of redeemkey of omni_createrawtx_multisig (dexX7)

Pull request description:

  This pull request fixes faulty parsing of redeem key of omni_createrawtx_multisig.

Tree-SHA512: b04954cf34ab1c102cad0d622ddd212ff4a795706a7085078dd97f839fd0a0052b4e6eecdfb3fcb0636ca48a84a0d4b76efb52856d0b9203496e0c71dd1f812f

This change only affects comments, documentation, 
and RPC Help messages.

9dfa58f Fix typo: depreciated -> deprecated (Sean Gilligan)

Pull request description:

  See https://www.merriam-webster.com/dictionary/deprecate

  This change only affects comments, documentation,
  and RPC Help messages.

Tree-SHA512: 4b65f1911e428e20b1f02a10eb27452d90b16dab1fa8e33a895e786dee47e46a4ac7b141c4531116cadcd1414987de22b9028835632de1e08a8ee37b895dabbf

fbd6c39 Split string to maintain property ID (Peter Bushnell)

Pull request description:

Tree-SHA512: a1f2eb1cbff14f905814aab6d25ed5c9abaf0489833520dac7bacdedbf8af3ff521cf160d5193c4fde08d3b414d1ebf5d6411d4bdb89bd03170acbab47e8010d

New RPCs:

- omni_sendnewdexorder
- omni_sendupdatedexorder
- omni_sendcanceldexorder

When the node is not synchronized, transaction inputs need to be provided explicitly. When this is not the case, a proper error is now shown:

> "Transaction inputs were not found. Please provide inputs explicitly (see help description) or fully synchronize node."

56a05fe Add error text for omni_decodetransaction, when inputs are missing (dexX7)

Pull request description:

  When the node is not synchronized, transaction inputs need to be provided explicitly. When this is not the case, a proper error is now shown:

  > "Transaction inputs were not found. Please provide inputs explicitly (see help description) or fully synchronize node."

  It resolves #1110.

Tree-SHA512: d2de932e423065a22c0bde73ba148abbd2d323ff3a1fe92fcb48a3b30f5ae8eb47d51867d88b0f12e7692e054809824560d9bfc38d5a537f7ea1db30206491f8

dae8745 Bump version to Omni Core 0.8.2 (dexX7)

Pull request description:

  This pull request updates the version to 0.8.2.

Tree-SHA512: 208db2af0acf79164cb6fcf2d0982cbb39e06bda2d70bd2df1c50b9f2824dc7dccb18d573742e94929e81bb8d13de94c038402714af063659b3748e002cd3bd8

c37ffc3 omni_getactivedexsells display indivisible tokens correctly (Peter Bushnell)
6e242b4 Corrections to DEx pay call (Bushstar)

Pull request description:

Tree-SHA512: a60e26ba6b0401385e84ba498a1debca7ce5a84d4c79d07bff96d5f636b2044bd52ad6c97b3a11ac072a775c18b48aa4135b03c63041a0c96dacf0542b750291

dbe285d Add security policy (dexX7)

Pull request description:

  This pull request adds a basic security policy.

Tree-SHA512: 2009049a7a318fbaf4847a77be4947509ac3080b5b8ef7e7220feab11c34a330480a010345f1e0b65eee532437c88324c0e35426301712fc342bd1bb674b937f

The fields "issuer", "creationtxid", "fixedissuance" and "managedissuance" are now included, when using "omni_listproperties".

c93ef3c Add more information when listing tokens (dexX7)

Pull request description:

  The fields "issuer", "creationtxid", "fixedissuance" and "managedissuance" are now included, when using "omni_listproperties".

  The call now returns similar results as "omni_getproperty".

Tree-SHA512: a0c3c365e8b144cbcab1e1ad466382932523e1a7eaa96d1faf789ea354e7b03fa409c0b35fbaf35592413333a5ff5eed1937f4d4a9407a1a1bfe44c7bed25500

0c378e0 Corrections to display of DEx info (Peter Bushnell)

Pull request description:

Tree-SHA512: f4aa079b211c5822aee0336897c25a57c0337bc91c38e9d7242501ae19e8506767fb7aa7c795edff6fc06faf469ef86e376cd827c8a7207fbb429e512199a04d

95484a7 Return proper accept reserve balance, fix formating (dexX7)
c37ffc3 omni_getactivedexsells display indivisible tokens correctly (Peter Bushnell)
6e242b4 Corrections to DEx pay call (Bushstar)
8f13b84 Update documentation for new DEx RPCs (dexX7)
f25cf8b Add seperate RPCs for each DEx 1 action (dexX7)

Pull request description:

  New RPCs:

  - omni_sendnewdexorder
  - omni_sendupdatedexorder
  - omni_sendcanceldexorder

Tree-SHA512: 6c65898b15ed373c4b434abd918193cc31f1d42116f7e787af43606983e40718126edb1142f874993beec576533010dafc32c6f7fd410cd1d3290547d7db31b0

babf9f0 Pay exact amount for divisible tokens (Peter Bushnell)

Pull request description:

Tree-SHA512: 880a6ba1278b5138cbd8ecfbb835f961a014dda9a3cdc5c295cdd67cdf622e1d6be1eefabdecaeb29dcfc6326c9c7f7524bf96a7569ee1ff4c5c4dbcbaff38d6

ca26920 Add release notes for Omni Core 0.8.2 (dexX7)

Pull request description:

  This pull request updates the release notes for 0.8.2.

Tree-SHA512: a41de962139eae3041dfe9d9541975a8ccf0a09776e0b6d7ef0ec6b634da13045ba018d0ab9d6e0e3ae21b06b747063eca4e711aae6488705fbf0d4a8290560f

Add experimental warning to README

a080849 Remove OpenSSL usage from Omni source (Peter Bushnell)

Pull request description:

  OpenSSL has been removed in Bitcoin 0.20. The commit here is to remove OpenSSL usage from Omnicore to prepare for versions of Omnicore based on Bitcoin 0.20+.

Tree-SHA512: 445ba7acf181996296cc74d3dbb61ff2fc1f9deaca5ab48d92ab3c7efc02b418032ef2670c85ac1d0be962e9996675c32ee30a813289955bfd77c51829306568

2830c58 Change Regtest RPC port to Bitcoin 0.16+ default (Bushstar)

Pull request description:

Tree-SHA512: 2820d0e37b91770b3c7155b3173b5be673eb6f552730e871ed208c3220c6e34397dafcae79be93214083c05cd8e419493a37cc03a61f71a78df9b17e1701d64d

Merge Bitcoin 0.20 into omnicore

Use legacy signing provider

eb545d3 Travis OmniJ tests: upgrade to jdk 11 (from JDK 8) (Sean Gilligan)

Pull request description:

  Upgrade `.travis.yml` to install OpenJDK 11 (rather than OpenJDK 8) for OmniJ tests.

Tree-SHA512: 53c3d3d35a72ea43f611d92150b252f1a021f31d32b14515a4908b0de5f3a5ae27ac27a2b048a1a40b2a7717ea2066b2459c47770b5e762e05929e2c4e4faf86

Travis OmniJ tests: upgrade to jdk 11 (from JDK 8)

Hold mempool.cs to avoid potential deadlock

6b2047a [tests] Check Omni token balance is consistent after reorg (Peter Bushnell)
8be8eac [tests] Update functional test framework for Omni (Peter Bushnell)

Pull request description:

  Update the functional test framework for Omni, this requires typically minor changes due to name changes, prune mode not being supported, additional RPC help info, bespoke uacomment and address and change type being set to legacy.

  A test is added to make sure that after a reorg token balances are consistent between nodes.

  Functional tests have been added to the OmniJ build on Travis.

  Also update spellcheck as the previous version generates an "outdated URL" error, see the following commit for more info.

  https://github.com/bitcoin/bitcoin/commit/39d526bde48d98af4fa27906e85db0399b6aa8b1

Tree-SHA512: 2c9f5cf1e704a8c49d6c933812693a0862614da33245d51c04817f3bd58fa599ccdf247b427153f2082c4f1cb7a483bfc12044b3c8ca60b43f796269030b598c

Check Omni token balance is consistent after reorg

[tests] Add tests for CreateFundedTransaction

cc6044b [tests] CreateFundedTransaction (Peter Bushnell)

Pull request description:

  Adds three test cases for CreateFundedTransaction, funding with source address, funding with receiver address and funding with fee address. Expected number of the outputs are also checked.

Tree-SHA512: 4ad3122cc7245c9a2c2787cb0033ce98ad2613b25344ead53fbbd2fc720cba27c1a63da851bd4ee002162bb4a1bc477bbfaef3671fb4862d00097579e9e9a96d

3e22efd [tests] Convert bash test scripts to functional test framework (Peter Bushnell)
da477a6 [rpc] Correction to help info (Peter Bushnell)

Pull request description:

  There are several bash scripts that cover functionality that is not covered by CI. These tests are ported here to the Python functional test framework and will now be run by CI. Minor correction was made to an RPC calls help info as this came up during porting.

Tree-SHA512: d947a59aeec9ee50a1af3cff82b1d5de8bbebbae160565f31e2dbdfad300edda9726bbbaf23a53d4d9c9e75de5f6829d8860ff2b845f6fee6931908fba302b80

[tests] Convert bash test scripts to functional test framework

5d21997 Set default address type to P2SH_SEGWIT (Peter Bushnell)

Pull request description:

  Change the default address type to P2SH-SegWit. Also restore the address type functional tests which was previously incompatible and update the wallet_import_rescan.py test work with this change.

Tree-SHA512: 63d37289d8ef4dae505514bda8cd96d5be73b52dc7513c8d78a3abb6a908b87af37de8db924c0951b822748c649e4a535f56a01d440b454b911bc64c243c5ac4

Set default address type to P2SH_SEGWIT

The transaction type is optional and not consensus affecting. It does not change the consensus hash.

The new transaction allows to embed arbitrary data and has the tranasaction identifier 200.

4beb87a Add new transaction type to embed any data (dexX7)

Pull request description:

  The new transaction allows to embed arbitrary hex-encoded data.

  It has the transaction identifier 200 and is not consensus affecting. It does not change the consensus hash.

  ---

  ### Example of sending and pulling data

  Sending the hex-encoded data:

  ```bash
  $ omnicore-cli "omni_sendanydata" "2N5bnBsaVdPBuK5xKCQ5ZTXnofBfwSxU2Th" "497420776f726b7321"
  ```
  ```
  4c9776f28e7015e840a05cb0955c22fd6917cf264032ad694e5d1ee0d8ebf745
  ```

  After a confirmation:

  ```bash
  $ omnicore-cli "omni_gettransaction" "4c9776f28e7015e840a05cb0955c22fd6917cf264032ad694e5d1ee0d8ebf745"
  ```
  ```js
  {
    "txid": "4c9776f28e7015e840a05cb0955c22fd6917cf264032ad694e5d1ee0d8ebf745",
    "fee": "0.00003240",
    "sendingaddress": "2N5bnBsaVdPBuK5xKCQ5ZTXnofBfwSxU2Th",
    "ismine": true,
    "version": 0,
    "type_int": 200,
    "type": "Embed any data",
    "data": "497420776f726b7321",
    "valid": true,
    "blockhash": "7c1e8be2c48fa6062b2b8ff6de7b2e1bc14b7d281d961979ed195a86399abd75",
    "blocktime": 1599469254,
    "positioninblock": 1,
    "block": 367,
    "confirmations": 1
  }
  ```

  ---

  ### RPC description: omni_sendanydata

  Create and broadcast a transaction with an arbitrary payload.

  **Arguments:**

  | Name                | Type    | Presence | Description                                                                                  |
  |---------------------|---------|----------|----------------------------------------------------------------------------------------------|
  | `fromaddress`       | string  | required | the address to send from                                                                     |
  | `data`              | string  | required | the hex-encoded data                                                                         |

  **Result:**
  ```js
  "hash"  // (string) the hex-encoded transaction hash
  ```

  **Example:**

  ```bash
  $ omnicore-cli "omni_sendanydata" "3M9qvHKtgARhqcMtM5cRT9VaiDJ5PSfQGY" "646578782032303230"
  ```

  ---

  ### RPC description: omni_createpayload_anydata

  Creates the payload to embed arbitrary data.

  **Arguments:**

  | Name                | Type    | Presence | Description                                                                                                 |
  |---------------------|---------|----------|----------------------------------------------------------------------------------------------|
  | `data`              | string  | required | the hex-encoded data                                                                         |

  **Result:**
  ```js
  "payload"  // (string) the hex-encoded payload
  ```

  **Example:**

  ```bash
  $ omnicore-cli "omni_createpayload_anydata" "646578782032303230"
  ```

  ---

Tree-SHA512: 749a26686b210693f393891a4a1a497154cb761cf3342bbc76e23a8ea2c9f55804a5562e9950322240d5e2d2092829d1fd9dab778686bc270e4d2e3aac005503

27f30e7 Support adding a receiver address for "any data" transactions (dexX7)

Pull request description:

  The new transaction 200 now supports also an optional receiver address.

  ### Example: No receiver specified

  ```
  omni_sendanydata "2MsKdZp2EztZZXv3P17dmjEt9VUdb698wiL" "0101"
  ```
  ```
  fdc754f8f4931412f8398ff76e518cc29d403acddf995a9f5efb5c98451c9ee9
  ```

  ```
  omni_gettransaction "fdc754f8f4931412f8398ff76e518cc29d403acddf995a9f5efb5c98451c9ee9"
  ```
  ```
  {
    "txid": "fdc754f8f4931412f8398ff76e518cc29d403acddf995a9f5efb5c98451c9ee9",
    "fee": "0.00003100",
    "sendingaddress": "2MsKdZp2EztZZXv3P17dmjEt9VUdb698wiL",
    "referenceaddress": "2MsKdZp2EztZZXv3P17dmjEt9VUdb698wiL", # <-- with no receiver given, receiver = sender
    "ismine": true,
    "version": 0,
    "type_int": 200,
    "type": "Embed any data",
    "data": "0101",
    "confirmations": 0
  }
  ```

  ### Example: One receiver specified

  ```
  omni_sendanydata "2MsKdZp2EztZZXv3P17dmjEt9VUdb698wiL" "0202" "2N85ZZpYLqEvTRbuVzFzfXMRWqxbQm3v46Q"
  ```
  ```
  b259dba9dcedecfb095a00f1540a09fcffc0fc3d5863c5a408d206886a24d2d9
  ```

  ```
  omni_gettransaction "b259dba9dcedecfb095a00f1540a09fcffc0fc3d5863c5a408d206886a24d2d9"
  ```
  ```
  {
    "txid": "b259dba9dcedecfb095a00f1540a09fcffc0fc3d5863c5a408d206886a24d2d9",
    "fee": "0.00003740",
    "sendingaddress": "2MsKdZp2EztZZXv3P17dmjEt9VUdb698wiL",
    "referenceaddress": "2N85ZZpYLqEvTRbuVzFzfXMRWqxbQm3v46Q", # <-- the specified receiver
    "ismine": true,
    "version": 0,
    "type_int": 200,
    "type": "Embed any data",
    "data": "0202",
    "confirmations": 0
  }
  ```

Tree-SHA512: bb37e3efb2bfe4507573ee89acca0d03a0f9f67dc45b35a506b7f8ef362bbbdda2473f5673f012b87d75e4f3bd555551398bd2f2a49b395be70fd8213196dace

40f9c8e Avoid overflow trap on reindex with debug enabled (Peter Bushnell)

Pull request description:

  When reindexing mainnet with --debug-enabled which sets -ftrapv, exceptions are generated from an overflow in FormatDivisibleMP, this happens when Omni TXs that are in error and have the value -9223372036854775808 hit the following line in FormatDivisibleMP.

  https://github.com/OmniLayer/omnicore/blob/master/src/omnicore/omnicore.cpp#L196

  -9223372036854775808 when negated as 9223372036854775808 is in overflow and crashes with trapv set.

  This was avoided in the past for a normal sync with the following commit.

  https://github.com/OmniLayer/omnicore/commit/eb8a9865c2793ae47123668bbba40b57b0345e23

  This commit reverts the commit above and if the value passed to FormatDivisibleMP or FormatDivisibleShortMP is the minimum possible value then the string "ErrorAmount" is returned and the code generating the exception is skipped.

Tree-SHA512: b4e5f62905145b6bb59e24071f56b2088ba659b2f751e3ee9b9da82b1eed9cd8b994257fbb7a0d36621b4c66e656b0a2e42030a9f6dbabbd039520bf165c86c4

Avoid overflow on reindex with debug enabled

5e6d739 Add Bitcore indexing to Omnicore (Peter Bushnell)

Pull request description:

  This adds the following RPC calls to the Omni client, to access them configure needs to be run with <code>--enable-bitcore-rpc</code>, indexing needs to be enabled in bitcoin.conf file with <code>addressindex=1</code>.

  ```
  getaddresstxids
  Returns the txids for an address(es)
  ```
  ```
  getaddressdeltas
  Returns all changes for an address
  ```
  ```
  getaddressbalance
  Returns the balance for an address(es)
  ```
  ```
  Returns all unspent outputs for an address
  getaddressutxos
  ```
  ```
  getaddressmempool
  Returns all mempool deltas for an address
  ```
  ```
  getblockhashes
  Returns array of hashes of blocks within the timestamp range provided
  ```
  ```
  getspentinfo
  Returns the txid and index where an output is spent
  ```

Tree-SHA512: 331e4f529c34513bf8e1595799dd5d89d758988503e1eec4f8bc1ec713bfc107eadb48051933799fecce9b2568f0b43f5a56771dbc838e4bd7068881dfbc5b95

e9052fa Bump version to 0.9.0 (dexX7)

Pull request description:

  Increase version of Omni Core to 0.9.0.

Tree-SHA512: 58cf966c8a7584f7d63de91a2437fa2da3a8da47bfe43d6644be042b26cd5dda058e0f6894a5ba4e4cf3a037cd3224261bad64c0d07e5bb2d2689d6d51fa37c4

c139ae4 Add description for -experimental-btc-balances (dexX7)

Pull request description:

  Add a description for the new -experimental-btc-balances option.

Tree-SHA512: dc3c659a9d08b4ada5bb9b04c4488182d62366485e2f7b476ac2def7ebfeffb16d054f3662abb7dc40a0bc06df5049175baac19143f3022ffd53f386b7be857f

The transaction type is optional and not consensus affecting. It does not change the consensus hash.

The new transaction allows to embed arbitrary data and has the tranasaction identifier 200.

2086d0d Move lock to blockOnchainActive (Peter Bushnell)

Pull request description:

  Currently cs_main in getblockhashes is only held in the scope of the fActiveOnly conditional and is immediately released. cs_main is supposed to be held for the call to blockOnchainActive based on fActiveOnly being true.

  This is the path from getblockhashes to blockOnchainActive when fActiveOnly is true.

  getblockhashes > GetTimestampIndex > ReadTimestampIndex > blockOnchainActive

  This commit removes the cs_main lock from getblockhashes and moves it to blockOnchainActive before BlockIndex() and ChainActive() is used. blockOnchainActive needs to hold cs_main for BlockIndex() and ChainActive().

Tree-SHA512: a216e117ebc88ce5f630cbccdc37324d71563ebc55cdc86a3f068369c3cd1fd184e902f8af127168493b59cbce807e63be08f520de0b3241021070718238f639

c7d1951 Return error, when using bitcore RPCs without addrindex (dexX7)

Pull request description:

  When the address index (bitcore patch) isn't enabled, return an error, when using the related RPCs.

Tree-SHA512: 13aaeab45ae4b74ddb376549d2d4f8240454b934a097c478759825ea321b96c2ebea77c3193251f21abc590f19240f24e77b3f14ab0fe818016ab9e276d4d6ba

2c11a8f Add documentation for address index RPCs (dexX7)

Pull request description:

  Add JSON-RPC API documentation for address index RPCs.

Tree-SHA512: 322265974648425a59eecd187a93d5802675824a030a00716291cdf9395ec64dfb3177b9f948136b6ded7398e3e762365d871401c26d9791d4892a0120ab9d70

92e9961 Add release notes for Omni Core 0.9.0 (dexX7)
b2e5035 Move old release notes into release notes folder (dexX7)

Pull request description:

  Add release notes for Omni Core 0.9.0.

Tree-SHA512: 9f662c0c6fbf66f6fc86311718186ece85f7af75006b2cfaa2a13af6d45a02c6be9fd21e72030ddd51bda65a956ba872a9f3a6824014592a780f588ea61ad51b

Add new transaction type to embed any data

Add bitcore indexing

They have been missing since buried deployments were merged

This is needed to compile with Qt 5.15.

Github-Pull: #19097
Rebased-From: 79b0a69e09c1a912122e6431ea3c530cc292c690

Pthread library does not set errno.
Pthread library's errno is returned by return value.

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

Github-Pull: #19194
Rebased-From: cb38b069b0f41b1a26264784b1c1303c8ac6ab08

Github-Pull: #19152
Rebased-From: 0fef60c63d6d2f4df8e698936221e2330ef3a244

These haven't been updated since their addition, so this updates the list that
controls which qt base translations are bundled with the macOS binary, to all the
languages that are available with qt 5.9.8.

This could probably be improved in some way, however qt updates are infrequent,
and I didn't want to spend any more time looking at this. Also given that no-one
seems to have noticed and/or reported this it wouldn't seem high-priority.

Could be backported to 0.20.1.

Github-Pull: #19059
Rebased-From: 69bfcac27a83440092bc6e61904ded910ed4baf4

Co-authored-by: sipa <pieter@wuille.net>

Github-Pull: #18700
Rebased-From: e8fa0a3d2025509fcddc59fc618e91371542cf87

This fix is a based on the fix by Antoine Riard <ariard@student.42.fr> in
https://github.com/bitcoin/bitcoin/pull/18600.

Unlike that PR, which implements some new behavior, this just restores previous
wallet notification and status behavior for transactions removed from the
mempool because they conflict with transactions in a block. The behavior was
accidentally changed in two `CWallet::BlockConnected` updates:
a31be09bfd77eed497a8e251d31358e16e2f2eb1 and
7e89994133725125dddbfa8d45484e3b9ed51c6e from
https://github.com/bitcoin/bitcoin/pull/16624, causing issue
https://github.com/bitcoin/bitcoin/issues/18325.

The change here could be improved and replaced with a more comprehensive
cleanup, so it includes a detailed comment explaining future considerations.

Fixes #18325

Co-authored-by: Antoine Riard <ariard@student.42.fr>

Github-Pull: #18982
Rebased-From: b604c5c8b5892842f13dee89ae31812a28ab25d1

https://github.com/bitcoin/bitcoin/pull/18982#pullrequestreview-416974841

Github-Pull: #18982
Rebased-From: 7eaf86d3bfc83f2beb3ef449707d5156853126fb

Github-Pull: #19215
Rebased-From: 72f6bec1da198764d4648a10a61c485e7ab65e9e

Github-Pull: #19215
Rebased-From: 5279d8bc07d601fe6a67ad665fbc7591fe73c7de

Offline signers will always need a non_witness_utxo so make sure it is
there.

Github-Pull: #19215
Rebased-From: 46004790588c24174a0bec49b540d158ce163ffd

Github-Pull: #19215
Rebased-From: 84d295e51341a126a6c3cbeea7a8caa04c7b5bc3

Github-Pull: #19300
Rebased-From: b9971ae5853c1d62e09d976a8705f4f731290d85

Github-Pull: #19300
Rebased-From: 9b009fae6e2eb0ab2ee7ce7882c3556a9ac363a7

This has been removed from the master branch, and always seems to fail
at the installing packages phase. i.e:
```bash
pkg install -y autoconf automake boost-libs git gmake libevent libtool pkgconf python3 ccache
Updating FreeBSD repository catalogue...
Fetching meta.txz: . done
pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2
repository FreeBSD has no meta file, using default settings
Fetching packagesite.txz: .......... done
pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2
pkg: Repository FreeBSD load error: meta cannot be loaded No error: 0
Unable to open created repository FreeBSD
Unable to update repository FreeBSD
Error updating repositories!

Exit status: 3
```

This patch improves performance and resource usage around IP
addresses that are banned for misbehavior. They're already not
actually banned, as connections from them are still allowed,
but they are preferred for eviction if the inbound connection
slots are full.

Stop treating these like manually banned IP ranges, and instead
just keep them in a rolling Bloom filter of misbehaving nodes,
which isn't persisted to disk or exposed through the ban
framework. The effect remains the same: preferred for eviction,
avoided for outgoing connections, and not relayed to other peers.

Also change the name of this mechanism to better reflect reality;
they're not banned, just discouraged.

Contains release notes and several interface improvements by
John Newbery.

Github-Pull: #19219
Rebased-From: b691f2df5f7d443c0c9ee056ab94aa0fc19566d5

Github-Pull: #19219
Rebased-From: 2ad58381fffb33d611abf900b73d9e6b5a4e35f8

Github-Pull: #18640
Rebased-From: fac0c8db9f634ea7231fb0b6dc139ae0bda4a051

Github-Pull: #19444
Rebased-From: 961e667600441c35845fcb36b120500c813cd3ed

Github-Pull: #19517
Rebased-From: 75122780e2c46505d977e24c5612dfa9442ab754

This change partially reverts 248e22bbc0d7bc40ae3584d53a18507c46b0e553.

Github-Pull: #19536
Rebased-From: 6457361e90c0cf704d086c51d75f51dbdfd374d7
Tree-SHA512: 3b48c64f59068d70b3aec4514ebe4a091813c77518a52a81bd8a36b44d0854b3f5e187f52c0f8e4527506087cb7e2cafb7c39cb7d28e4b8f620a77980e8a4697

Tree-SHA512: 643ff61093258641e0d69456cc6fbb8c47801af494aacbf3d3f6401ce9ea8f171d27b0703845fd581dbda8037b97c2b428ed92853909d49f251a4666fe8dae9a

Tree-SHA512: 9707cb25e7020d9db6005066675256ee34c689cf8f04586051501bb3a89f2c4eee222a39cd4c2a648dca8274f0fcf2d6aeee010cd3525ca8edae2ad2ffae9811

Tree-SHA512: b03b180f9ade0e6f74a722c9704725674abc8bdfdaed4579ed3b0569c6b584359a4696821d07c070887284c9876785ae92b1ccdc11fece0d505040e97fe81413

Tree-SHA512: 39bbead4040097dd8aeac13bed57ad5e698aa2453883d8259930399e3c0f51168913a991f303a3407b649cfbf6e223291ca0942119514060e9a164bd05fa91f5

Tree-SHA512: 7edd91cdb03cf55201987775e5d14bfa61e3eff54abd04eaf249889e5216b12ad722188e12bb51eabb81bcd66014fd349484533744dc777e7af68a78fbc7f51b

Our policy checks for non-standard inputs depend only on the non-witness
portion of a transaction: we look up the scriptPubKey of the input being
spent from our UTXO set (which is covered by the input txid), and the p2sh
checks only rely on the scriptSig portion of the input.

Consequently it's safe to add txids of transactions that fail these checks to
the reject filter, as the witness is irrelevant to the failure. This is helpful
for any situation where we might request the transaction again via txid (either
from txid-relay peers, or if we might fetch the transaction via txid due to
parent-fetching of orphans).

Further, in preparation for future witness versions being deployed on the
network, ensure that WITNESS_UNKNOWN transactions are rejected in
AreInputsStandard(), so that transactions spending v1 (or greater) witness
outputs will fall into this category of having their txid added to the reject
filter.

Github-Pull: #19620
Rebased-From: 7989901c7eb62ca28b3d1e5d5831041a7267e495

Github-Pull: #19620
Rebased-From: 9f88ded82b2898ca63d44c08072f1ba52f0e18d7

Latest vm version has updated cmake and the berkeleydb vcpkg now fails to build.

Due to the use of boost::filesystem::canonical(), the minimum required
version of Boost is actually 1.48.0. Use of canonical was introduced
in #14146.

See also Boost filesystem 1.48.0 release notes:
https://github.com/boostorg/filesystem/blob/6b5e38134a336b6ea777cd8a69b6ae929819db7e/doc/release_history.html#L508

NotifyEntryRemoved is redundant in 0.20 as TransactionRemovedFromMempool provides that behaviour so it was removed. This change was initially reverted in the initial port of Omni for compatibility. This commit restores the change in 0.20 and moves the marker cache removal to just after TransactionRemovedFromMempool is called.

Omni update version and documentation to 0.9.0 release

Return error, when using bitcore RPCs without addrindex

Show Omni version on splashscreen

Bitcoin 0.20.1

make[2]: Entering directory '/omnicore-src/omnicore-0.9.0/src'
  CXX      omnicored-bitcoind.o
  CXX      libbitcoin_server_a-addrdb.o
  CXX      libbitcoin_server_a-addrman.o
  CXX      libbitcoin_server_a-banman.o
  CXX      libbitcoin_server_a-bloom.o
  CXX      libbitcoin_server_a-blockencodings.o
  CXX      libbitcoin_server_a-blockfilter.o
  CXX      libbitcoin_server_a-chain.o
  CXX      libbitcoin_server_a-checkpoints.o
  CXX      libbitcoin_server_a-httprpc.o
  CXX      libbitcoin_server_a-httpserver.o
httpserver.cpp:74:10: error: 'deque' in namespace 'std' does not name a template type
   74 |     std::deque<std::unique_ptr<WorkItem>> queue;
      |          ^~~~~
httpserver.cpp:33:1: note: 'std::deque' is defined in header '<deque>'; did you forget to '#include <deque>'?
   32 | #include <support/events.h>
  +++ |+#include <deque>
   33 |
httpserver.cpp: In member function 'bool WorkQueue<WorkItem>::Enqueue(WorkItem*)':
httpserver.cpp:92:13: error: 'queue' was not declared in this scope; did you mean 'Enqueue'?
   92 |         if (queue.size() >= maxDepth) {
      |             ^~~~~
      |             Enqueue
httpserver.cpp:95:9: error: 'queue' was not declared in this scope; did you mean 'Enqueue'?
   95 |         queue.emplace_back(std::unique_ptr<WorkItem>(item));
      |         ^~~~~
      |         Enqueue
httpserver.cpp: In member function 'void WorkQueue<WorkItem>::Run()':
httpserver.cpp:106:35: error: 'queue' was not declared in this scope; did you mean 'Enqueue'?
  106 |                 while (running && queue.empty())
      |                                   ^~~~~
      |                                   Enqueue
httpserver.cpp:110:31: error: 'queue' was not declared in this scope; did you mean 'Enqueue'?
  110 |                 i = std::move(queue.front());
      |                               ^~~~~
      |                               Enqueue
make[2]: *** [Makefile:8739: libbitcoin_server_a-httpserver.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/omnicore-src/omnicore-0.9.0/src'
make[1]: *** [Makefile:15166: all-recursive] Error 1
make[1]: Leaving directory '/omnicore-src/omnicore-0.9.0/src'
make: *** [Makefile:788: all-recursive] Error 1

a0c7c30 fix build error for missing deque (lcgogo)

Pull request description:

  make[2]: Entering directory '/omnicore-src/omnicore-0.9.0/src'
    CXX      omnicored-bitcoind.o
    CXX      libbitcoin_server_a-addrdb.o
    CXX      libbitcoin_server_a-addrman.o
    CXX      libbitcoin_server_a-banman.o
    CXX      libbitcoin_server_a-bloom.o
    CXX      libbitcoin_server_a-blockencodings.o
    CXX      libbitcoin_server_a-blockfilter.o
    CXX      libbitcoin_server_a-chain.o
    CXX      libbitcoin_server_a-checkpoints.o
    CXX      libbitcoin_server_a-httprpc.o
    CXX      libbitcoin_server_a-httpserver.o
  httpserver.cpp:74:10: error: 'deque' in namespace 'std' does not name a template type
     74 |     std::deque<std::unique_ptr<WorkItem>> queue;
        |          ^~~~~
  httpserver.cpp:33:1: note: 'std::deque' is defined in header '<deque>'; did you forget to '#include <deque>'?
     32 | #include <support/events.h>
    +++ |+#include <deque>
     33 |
  httpserver.cpp: In member function 'bool WorkQueue<WorkItem>::Enqueue(WorkItem*)':
  httpserver.cpp:92:13: error: 'queue' was not declared in this scope; did you mean 'Enqueue'?
     92 |         if (queue.size() >= maxDepth) {
        |             ^~~~~
        |             Enqueue
  httpserver.cpp:95:9: error: 'queue' was not declared in this scope; did you mean 'Enqueue'?
     95 |         queue.emplace_back(std::unique_ptr<WorkItem>(item));
        |         ^~~~~
        |         Enqueue
  httpserver.cpp: In member function 'void WorkQueue<WorkItem>::Run()':
  httpserver.cpp:106:35: error: 'queue' was not declared in this scope; did you mean 'Enqueue'?
    106 |                 while (running && queue.empty())
        |                                   ^~~~~
        |                                   Enqueue
  httpserver.cpp:110:31: error: 'queue' was not declared in this scope; did you mean 'Enqueue'?
    110 |                 i = std::move(queue.front());
        |                               ^~~~~
        |                               Enqueue
  make[2]: *** [Makefile:8739: libbitcoin_server_a-httpserver.o] Error 1
  make[2]: *** Waiting for unfinished jobs....
  make[2]: Leaving directory '/omnicore-src/omnicore-0.9.0/src'
  make[1]: *** [Makefile:15166: all-recursive] Error 1
  make[1]: Leaving directory '/omnicore-src/omnicore-0.9.0/src'
  make: *** [Makefile:788: all-recursive] Error 1

  Pull requests without a rationale and clear improvement may be closed
  immediately.

  Please provide clear motivation for your patch and explain how it improves
  Omni Core user experience or Omni Core developer experience
  significantly.

  * Any test improvements or new tests that improve coverage are always welcome.
  * All other changes should have accompanying unit tests (see `src/test/`) or
    functional tests (see `test/`). Contributors should note which tests cover
    modified code. If no tests exist for a region of modified code, new tests
    should accompany the change.
  * Bug fixes are most welcome when they come with steps to reproduce or an
    explanation of the potential issue as well as reasoning for the way the bug
    was fixed.
  * Features are welcome, but might be rejected due to design or scope issues.
    If a feature is based on a lot of dependencies, contributors should first
    consider building the system outside of Omni Core, if possible.
  * Refactoring changes are only accepted if they are required for a feature or
    bug fix or otherwise improve developer experience significantly. For example,
    most "code style" refactoring changes require a thorough explanation why they
    are useful, what downsides they have and why they *significantly* improve
    developer experience or avoid serious programming bugs. Note that code style
    is often a subjective matter. Unless they are explicitly mentioned to be
    preferred in the [developer notes](/doc/developer-notes.md), stylistic code
    changes are usually rejected.

  Omni Core has a thorough review process and even the most trivial change
  needs to pass a lot of eyes and requires non-zero or even substantial time
  effort to review. There is a huge lack of active reviewers on the project, so
  patches often sit for a long time.

Tree-SHA512: 258d53430e321f9834a0193eb833e1687fc01f738b348601acb54838c5e80e395fa051f46dd65d804dbb416530c37bf695720188dd66ba0773e7aa13c88e2891

a03f458 [tests] Test DEx versions using FreeDEx (Peter Bushnell)
6b52be2 [tests] check free DEx behaviour against DEx spec (Peter Bushnell)

Pull request description:

  Adds a Python functional test to check the DEx specification using the Free DEx feature which allows trading of properties other than OMNI and TOMNI.

  Also included is a minor fix for the omni_clientexpiry.py test as sometimes a JSONRPCException is thrown before an AssertionError.

Tree-SHA512: f71b3850869b10b82198b1d2ec810b15cbf99fa23e032de4f065dd6e1ab5196068ad98ac0ff80ace61a76f749c238f228b196b68f5800c34537e012162bddc20

bdfcd3b [tests] Add test for fee cache (Peter Bushnell)

Pull request description:

  Adding test for the fee cache feature.

  Dev MSC needs to be disabled for the tests, this is done with the new option -disabledevmsc that can only be used on regtest.

  UpdateDistributionThresholds needs to be called regardless of whether FEATURE_FEES is active, only EvalCache can be skipped. Otherwise distribution thresholds will be set to 0 for all tokens created, granted or revoked before FEATURE_FEES is active and those pre-activation tokens will not have their thresholds updated unless something changes their total supply.

Tree-SHA512: 09fc0503aaf1ed5c9312bab1194e8d4eddf2dc982069f5ce059ee157d0860b7f7bee750c0821a5ac41c93703a6dd620daa13b7e28e28af6585866c4d7b7d4fe8

73c44a4 Pass wallet from TxViewDelegate to IsMyAddress (Peter Bushnell)
7ad37db Set true for DEx or overview will always show DEx TXs as invalid (Peter Bushnell)

Pull request description:

  DEx transactions always show as invalid on the overview page. When ParseTransaction returns more than 0 indicating a DEx TX the code works out whether it is an outbound or inbound TX to update the icon but without setting valid to true an invalid icon is shown instead.

  The other change here is to pass a wallet to IsMyAddress, without this IsMyAddress will always return false so TXs on the overview page always appear to be outgoing, not incoming. The second wallet argument for IsMyAddress no longer has a default nullptr argument so a wallet must always be passed when calling it.

Tree-SHA512: acff3182fe6350d90e51362e950558c43aeac3d33990e01c0aca9c4e49e927147d357f400ee2f22c0e27a4ba8ea1c8c0b0022df168d4e84cee84706cd7d99e55

Pull request description:

  This pull request integrates Bitcoin Core 0.20.

Pull request description:

  Last two merges on the experimental branch did not make it into the recent merge of that branch into this develop branch. Missing merges linked in below.

  https://github.com/OmniLayer/omnicore/pull/1194
  https://github.com/OmniLayer/omnicore/pull/1195

  Also two files remained that should have been removed and there was a conflict in the .travis.yml file, that is the only merge conflict in the code and is remedied here.

Pull request description:

  Disable the ability to change the loaded wallet in the main Qt window as it does not yet properly work with tokens.

Pull request description:

  Update version to 0.9.99 to indicate ongoing development.

Pull request description:

  Calculate the specific amount and fee required when creating an Omni transaction.