Update string for Show/Hide in the tray #1617

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Show_Hide_string changing 1 files +2 −3

Diapolo commented at 11:05 AM on July 21, 2012: none
- be clear we don't "Show/Hide Bitcoins", but just the client window
- remove the tooltip for toggleHideAction as this is not shown anyway
laanwj commented at 12:06 PM on July 21, 2012: member

In that case, why not just "Show/Hide"? "Window" doesn't tell the user anything, either.
Diapolo commented at 12:27 PM on July 21, 2012: none

Window tells the user we are talking about the Client window, no? I'm fine with "Show / Hide" though :).
laanwj commented at 12:32 PM on July 21, 2012: member

It tells the user that what gets hidden/shown is a "window". Which is always the case... it's just too generic so better to leave it out.
Diapolo commented at 8:51 AM on July 26, 2012: none

@laanwj Do you agree with this small pull after the last rebase?
BitcoinPullTester commented at 1:20 AM on August 9, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ef5fc417f98c06c490ec47262eacbb5db2ffcf99 for binaries and test log.
Diapolo commented at 8:40 PM on August 13, 2012: none

@laanwj Anything I can do to get this small thing merged after 24 days :-D?
laanwj commented at 3:31 AM on August 14, 2012: member

Kind of lost track of this, github should really add a way to assign pull requests.

There is a string freeze for 0.7.0 now but it can be merged after that.
luke-jr commented at 3:46 AM on August 14, 2012: member

@laanwj Eh, GitHub does let you assign pull requests... you just need to do it from the Issues list
ghost assigned laanwj on Aug 17, 2012

Update string for Show/Hide in the tray

- be clear we don't "Show/Hide Bitcoins", but just the client window
- remove the tooltip for toggleHideAction as this is not shown anyway
- update a comment to be more general

e273c51287

Diapolo commented at 5:41 AM on August 29, 2012: none

@laanwj Is that string freeze still persistent or does this make it into 0.7 final? Just wanted to know :).
laanwj commented at 9:40 AM on August 29, 2012: member

Yes this can go into rc2, though we should merge it and push to transifex asap so people have a little time to translate it. Please remind me if I forget this today.
Diapolo commented at 9:42 AM on August 29, 2012: none

Will do that, btw. I always hope you don't feel set under pressure by my remainders :) but as GUI master I need you ^^.
laanwj referenced this in commit c7df832d7a on Aug 29, 2012
laanwj merged this on Aug 29, 2012
laanwj closed this on Aug 29, 2012
suprnurd referenced this in commit 91d99fcd3f on Dec 5, 2017
DrahtBot locked this on Sep 8, 2021

Contributors