RPC: Add aliases for priv and pub rpc calls #16187

pull emilengler wants to merge 1 commits into bitcoin:master from emilengler:master changing 2 files +17 −13

emilengler commented at 1:31 PM on June 11, 2019: contributor
Hello, this PR adds aliases for all privkey and pubkey rpc calls.<br> For example: importprivatekey does the same as importprivkey Same with importpublickey and importpubkey<br> Aliases that have been added
- importprivatekey => importprivkey
- importpublickey => importpubkey
- signmessagewithprivatekey => signmessagewithprivkey
I added the aliases because I did several typos in the past where I've written public and private instead of pub and priv.

However I haven't added the aliases to the help/qt autocompletion because I added them, as stated above, for typos.

Greetings Emil
Add aliases for priv and pub rpc calls 46adca47c4
fanquake added the label RPC/REST/ZMQ on Jun 11, 2019
promag commented at 1:39 PM on June 11, 2019: member

Concept NACK sorry, IMO there's no point in having aliases just because you type the wrong command.

Maybe an alternative is to have the aliases on the client side? Still I don't think it's worth it.
emilengler commented at 1:42 PM on June 11, 2019: contributor

@promag GNU for example also has aliases. dir is just an alias for ls
promag commented at 1:50 PM on June 11, 2019: member

@emilengler I'm aware of aliases, I just think the server doesn't have to deal with that.
kristapsk commented at 2:28 PM on June 11, 2019: contributor

Concept NACK, definitely not the right thing to do at the server side. If typos are the problem that needs to be solved (I doubt even that), can be done at client side. For bitcoin-cli typos can be solved better as an autocomplete module for the shell you use.
MarcoFalke commented at 2:46 PM on June 11, 2019: member

Closing for now. Seems too controversial. Indeed, we have autocomplete (in the gui) as well as for the shell.
MarcoFalke closed this on Jun 11, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels