Change window titles to "Bitcoin-Qt - <purpose>" / misc related renames #1620

luke-jr commented at 9:35 PM on July 22, 2012: member

This helps user to not think the client is called "Bitcoin"

in src/qt/bitcoingui.cpp:None in b1bea3b550 outdated

 266 | -    optionsAction->setToolTip(tr("Modify configuration options for Bitcoin"));
 267 | +    optionsAction->setToolTip(tr("Modify configuration options for Bitcoin-Qt"));
 268 |      optionsAction->setMenuRole(QAction::PreferencesRole);
 269 | -    toggleHideAction = new QAction(QIcon(":/icons/bitcoin"), tr("Show/Hide &Bitcoin"), this);
 270 | -    toggleHideAction->setToolTip(tr("Show or hide the Bitcoin window"));
 271 | +    toggleHideAction = new QAction(QIcon(":/icons/bitcoin"), tr("Show/Hide &Bitcoin-Qt"), this);

Diapolo commented at 10:29 PM on July 22, 2012:

I have a pull that removes any client name. Simply Show / Hide.

in src/qt/bitcoingui.cpp:None in b1bea3b550 outdated

 355 | @@ -356,7 +356,7 @@ void BitcoinGUI::setClientModel(ClientModel *clientModel)
 356 |  #endif
 357 |              if(trayIcon)
 358 |              {
 359 | -                trayIcon->setToolTip(tr("Bitcoin client") + QString(" ") + tr("[testnet]"));
 360 | +                trayIcon->setToolTip(tr("Bitcoin-Qt client") + QString(" ") + tr("[testnet]"));

Diapolo commented at 10:30 PM on July 22, 2012:

I would leave this as is, because Bitcoin-Qt is a Bitcoin client, so either Bitcoin-Qt or leave Bitcoin client, which is fine here IMHO.

luke-jr commented at 10:34 PM on July 22, 2012:

Bitcoin-Qt already uses the generic Bitcoin icon, so it makes sense to provide at least a little more detail in the tooltip IMO ;)

Diapolo commented at 10:43 PM on July 22, 2012:

If @laanwj will ever accept an official name of Bitcoin-Qt for the GUI client (which I like), this should perhaps be the description string from the meta-data pull I have open or we should harmonize this.

luke-jr commented at 10:53 PM on July 22, 2012:

Bitcoin-Qt has always been the official name of this Qt client.

in src/qt/bitcoingui.cpp:None in b1bea3b550 outdated

 415 | @@ -416,7 +416,7 @@ void BitcoinGUI::createTrayIcon()
 416 |      trayIcon = new QSystemTrayIcon(this);
 417 |      trayIconMenu = new QMenu(this);
 418 |      trayIcon->setContextMenu(trayIconMenu);
 419 | -    trayIcon->setToolTip(tr("Bitcoin client"));
 420 | +    trayIcon->setToolTip(tr("Bitcoin-Qt client"));

Diapolo commented at 10:30 PM on July 22, 2012:

Same as above!

in src/qt/bitcoingui.cpp:None in b1bea3b550 outdated

 452 | @@ -453,7 +453,7 @@ void BitcoinGUI::trayIconActivated(QSystemTrayIcon::ActivationReason reason)
 453 |  {
 454 |      if(reason == QSystemTrayIcon::Trigger)
 455 |      {
 456 | -        // Click on system tray icon triggers "show/hide Bitcoin"

Diapolo commented at 10:35 PM on July 22, 2012:

This should be just a more general comment, I have this in the mentioned pull.

in src/qt/forms/rpcconsole.ui:None in b1bea3b550 outdated

  35 | @@ -36,7 +36,7 @@
  36 |            </font>
  37 |           </property>
  38 |           <property name="text">
  39 | -          <string>Bitcoin Core</string>
  40 | +          <string>Client Core</string>

Diapolo commented at 10:36 PM on July 22, 2012:

I think client core is missleading here.

luke-jr commented at 10:39 PM on July 22, 2012:

I liked "Client" best. "Bitcoin Core" is more misleading.

Diapolo commented at 10:44 PM on July 22, 2012:

Bitcoin is the core technology and the client is using this ... that's how I think about it.

luke-jr commented at 10:55 PM on July 22, 2012:

Bitcoin is the blockchain and its protocol. Not software.

in src/qt/forms/rpcconsole.ui:None in b1bea3b550 outdated

 321 | @@ -322,7 +322,7 @@
 322 |         <item row="15" column="0">
 323 |          <widget class="QPushButton" name="openDebugLogfileButton">
 324 |           <property name="toolTip">
 325 | -          <string>Open the Bitcoin debug logfile from the current data directory. This can take a few seconds for large logfiles.</string>
 326 | +          <string>Open the Bitcoin-Qt debug logfile from the current data directory. This can take a few seconds for large logfiles.</string>

Diapolo commented at 10:37 PM on July 22, 2012:

Afaik this could be the same file to which bitcoind writes, no? So Leave as is.

luke-jr commented at 10:43 PM on July 22, 2012:

Could be, but it's also client-specific. How about "Open the debug log file from the current data directory. This can take a few seconds for large log files."

Diapolo commented at 10:50 PM on July 22, 2012:

ACK to writing "log file", I like nothing better than Bitcoin-Qt here ... but it is a client logfile, no matter if bitcoin-qt or bitcoind have written it, so what about "Open the clients debug log file from the current data directory. This can take a few seconds for large log files."?

Diapolo commented at 10:52 PM on July 22, 2012: none

In general I like to put the name Bitcoin-Qt in place as official client name, I just think it needs a finer thinking about where it makes sense and how.

Change window titles to "Bitcoin-Qt - <purpose>" / misc related renames

- This helps user to not think the client is called "Bitcoin"

c8758357f6

laanwj commented at 5:27 AM on July 23, 2012: member

NACK. I've been clear on this before. End users have no idea what "Qt" is, so it shouldn't appear that prominently in the interface. It's just a technical detail. Like putting the programming language in the title.

The focus should be on "Bitcoin" itself, not that it is a UI or what library happens to be used to build it.

luke-jr commented at 6:36 AM on July 23, 2012: member

@laanwj It's the client name. How are users to differentiate Bitcoin-Qt from other clients they may have installed? Specific clients shouldn't claim to be "Bitcoin" or it will confuse users into thinking Bitcoin is the software.

laanwj commented at 6:42 AM on July 23, 2012: member

That's not the client name. I think that's where the confusion comes from. Bitcoin-qt is the name of the UI project before it got merged into here. And the focus should be on the underlying system, not the UI. If this client has any name beyond "Bitcoin reference client" it's "Satoshi".

laanwj commented at 6:46 AM on July 23, 2012: member

Anyway, I'm fine with any name but I think naming should be @gavinandresen 's call as project lead.

luke-jr commented at 7:28 AM on July 23, 2012: member

I guess I see it as the same Bitcoin-Qt project mainly by @laanwj (ie, same maintainer = same project), and @gavinandresen the project lead of bitcoin_d_ (which happens to share the same git repository). I don't really care what you choose to name the client, but some distinction between Bitcoin and this Bitcoin client is needed.

Diapolo commented at 10:39 AM on July 23, 2012: none

Just for clarification, bitcoind is also a Bitcoin client, yes? When someone talks about bitcoind my association is hey that's the official / reference command-line Bitcoin client. If one talks about Bitcoin-Qt I associate the official / reference GUI Bitcoin client with it. That's no pro or con, I just want to understand what others read from a certain name.

To summarize: Bitcoin as the concept / protocol / technique bitcoind as command-line client using Bitcoin Bitcoin-Qt as GUI client using bitcoind

luke-jr commented at 3:17 PM on July 23, 2012: member

As I see it:

Bitcoin as the concept / protocol / technique / blockchain
"Satoshi" as the reference protocol implementation began by Satoshi Nakamoto, maintained by @gavinandresen
bitcoind as the JSON-RPC server began by Satoshi Nakamoto, maintained by @gavinandresen
Bitcoin-Qt as GUI client began and maintained by @laanwj

gavinandresen commented at 6:22 PM on July 23, 2012: contributor

I agree with laanwj, it's fine the way it is.

gavinandresen closed this on Jul 23, 2012

suprnurd referenced this in commit d7a8489f31 on Dec 5, 2017

DrahtBot locked this on Sep 8, 2021