Fixes #15648
Functional tests can fail and lcov still generates a coverage file, which is inaccurate. This change stops make from proceeding if functional tests fail.
before:
after:
test: stop generating lcov coverage when functional tests fail #16207
pull asood123 wants to merge 1 commits into bitcoin:master from asood123:patch-15648 changing 1 files +1 −1-
asood123 commented at 4:11 PM on June 13, 2019: contributor
-
Failing functional tests stop lcov 9218ce8d48
- DrahtBot added the label Build system on Jun 13, 2019
- DrahtBot added the label Tests on Jun 13, 2019
-
MarcoFalke commented at 4:48 PM on June 20, 2019: member
Concept ACK. Thanks for working on this!
-
laanwj commented at 5:45 PM on June 20, 2019: member
straightforward enough ACK 9218ce8d48e504aeaa983e82b206a386712e43e4
-
DrahtBot commented at 8:11 PM on June 20, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--2502f1a698b3751726fa55edcda76cd3-->
Coverage
Coverage Change (pull 16207, 6417c291887bbde7f2374a77073988e55521a062) Reference (master, 413e438ea9767710d4810c4400fd1242ca52cd1c) Lines -0.0278 % 89.0544 % Functions -0.0314 % 82.0481 % Branches -0.0244 % 45.1906 % <sup>Updated at: 2019-06-20T20:11:39.530365.</sup>
- MarcoFalke referenced this in commit b4ad4c0de3 on Jun 20, 2019
- MarcoFalke merged this on Jun 20, 2019
- MarcoFalke closed this on Jun 20, 2019
- sidhujag referenced this in commit 9a5c4cb2d0 on Jun 20, 2019
- deadalnix referenced this in commit ebdfa98dc4 on Feb 20, 2020
- ftrader referenced this in commit 25acd3ce4e on May 19, 2020
- Munkybooty referenced this in commit 4128f3020c on Oct 30, 2021
- Munkybooty referenced this in commit 87831d3fff on Oct 30, 2021
- Munkybooty referenced this in commit 65024e47bd on Nov 2, 2021
- Munkybooty referenced this in commit 81d6a880bb on Nov 2, 2021
- Munkybooty referenced this in commit 01a6da1eca on Nov 4, 2021
- Munkybooty referenced this in commit dda9c6b2e3 on Nov 16, 2021
- Munkybooty referenced this in commit feafa02be2 on Nov 18, 2021
- DrahtBot locked this on Dec 16, 2021
