gui: Translated messages should not be written to debug log (InitError, InitWarning, …) #16218

1. 
   MarcoFalke commented at 10:15 am on June 15, 2019: member

   Steps to reproduce:

   0$ ./src/qt/bitcoin-qt -lang=nl -blocksdir=/tmp/no/no -printtoconsole | grep 'no/no'
   12019-06-15T10:11:27Z Fout: Opgegeven blocks map "/tmp/no/no" bestaat niet.
   

   I think to fix this, we’d have to create a function similar to _(const char* psz), that does no translation, but makes gettext pick them up and then do something like #15340.

2. MarcoFalke added the label GUI on Jun 15, 2019
3. MarcoFalke added the label Utils/log/libs on Jun 15, 2019
4. MarcoFalke added the label good first issue on Jun 15, 2019
5. 
   hebasto commented at 10:22 pm on June 16, 2019: member

   ~#15340 reopened and rebased.~ #16224
6. MarcoFalke referenced this in commit 5b24f6084e on May 8, 2020
7. 
   MarcoFalke commented at 5:09 pm on May 8, 2020: member

   So the initial issue has been fixed. Some ideas for follow-ups:

   • InitWarning

   0$ ./src/qt/bitcoin-qt -lang=nl -debug=vladidation -printtoconsole | grep 'vladi'
   1Warning: Niet-ondersteunde logcategorie -debug=vladidation.
   22020-05-08T17:09:14Z [main] Warning: Niet-ondersteunde logcategorie -debug=vladidation.
   32020-05-08T17:09:21Z [qt-init] Command-line arg: debug="vladidation"
   

   • AbortNode, along with the style-fixes from #15894 (review)
8. 
   hebasto commented at 10:18 am on May 10, 2020: member

   So the initial issue has been fixed. Some ideas for follow-ups:

   * InitWarning
   

   0$ ./src/qt/bitcoin-qt -lang=nl -debug=vladidation -printtoconsole | grep 'vladi'
   1Warning: Niet-ondersteunde logcategorie -debug=vladidation.
   22020-05-08T17:09:14Z [main] Warning: Niet-ondersteunde logcategorie -debug=vladidation.
   32020-05-08T17:09:21Z [qt-init] Command-line arg: debug="vladidation"
   

   * AbortNode, along with the style-fixes from [#15894 (comment)](https://github.com/bitcoin/bitcoin/pull/15894#discussion_r297220395)
   

   Also InitMessage() should be added to this list.

9. 
   MarcoFalke commented at 12:27 pm on May 10, 2020: member

   Also SetMiscWarning
10. sidhujag referenced this in commit fc9f727a08 on May 12, 2020
11. jonasschnelli referenced this in commit 51825aea7f on May 13, 2020
12. sidhujag referenced this in commit 22afecdec6 on May 14, 2020
13. 
    MarcoFalke commented at 1:54 pm on May 15, 2020: member

    Steps to reproduce for SetMiscWarning:

    0LC_ALL=de_DE.UTF-8 QT_QPA_PLATFORM=minimal BITCOIND=bitcoin-qt ./test/functional/test_runner.py  --tracerpc feature_versionbits_warning.py
    

14. 
    MarcoFalke commented at 2:02 pm on May 15, 2020: member

    Also src/net_permissions.cpp: error = strprintf(_("Invalid P2P permission: '%s'").translated, permission); should not be translated unconditionally

    Steps to reproduce:

    0LC_ALL=de_DE.UTF-8 QT_QPA_PLATFORM=xcb BITCOIND=bitcoin-qt ./test/functional/p2p_permissions.py --tracerpc
    

15. 
    MarcoFalke commented at 9:52 pm on June 9, 2020: member

    So I think the last one to fix is SetMiscWarning
16. 
    hebasto commented at 9:50 am on June 10, 2020: member

    So I think the last one to fix is SetMiscWarning

    Done in #19233.

17. 
    MarcoFalke commented at 1:52 pm on June 10, 2020: member

    thx
18. MarcoFalke closed this on Jun 10, 2020

    ---

19. 
    hebasto commented at 3:48 pm on June 10, 2020: member

    #18927 is in progress yet.
20. MarcoFalke referenced this in commit 4b30c41b4e on Jun 16, 2020
21. sidhujag referenced this in commit f3dc64f18d on Jul 7, 2020
22. PastaPastaPasta referenced this in commit f83dd4f290 on Apr 5, 2022
23. PastaPastaPasta referenced this in commit 7a6f894184 on Apr 5, 2022
24. PastaPastaPasta referenced this in commit f5c87f1c39 on Apr 5, 2022
25. PastaPastaPasta referenced this in commit af00598c9a on Apr 7, 2022
26. PastaPastaPasta referenced this in commit be6c055f90 on Apr 7, 2022
27. PastaPastaPasta referenced this in commit 84f29d1082 on Apr 7, 2022
28. PastaPastaPasta referenced this in commit b0de56db6a on Apr 7, 2022
29. DrahtBot locked this on Aug 18, 2022

Contributors
MarcoFalke hebasto

Labels
GUI Utils/log/libs good first issue