The readme(s) are shipped in the released source-code archive, in which case the travis badge is useless since it doesn't link to the travis result of the correct commit/tag/branch. GitHub embeds the correct links for each tag or commit that ci ran on, so we don't need this link in the readme.
doc: Remove travis badge from readme #16243
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1906-docCleanCi changing 3 files +6 −8-
MarcoFalke commented at 3:53 PM on June 19, 2019: member
-
doc: Remove travis badge from readme e91f0a7af2
-
promag commented at 3:55 PM on June 19, 2019: member
ACK
- MarcoFalke added this to the milestone 0.19.0 on Jun 19, 2019
-
hebasto commented at 4:07 PM on June 19, 2019: member
ACK e91f0a7af2aec7d924f00da25c69d8f46e0dd33d I have reviewed docs and comments changes and they look OK, I agree they can be merged.
- DrahtBot added the label Docs on Jun 19, 2019
- DrahtBot added the label Tests on Jun 19, 2019
-
flack commented at 5:58 PM on June 19, 2019: contributor
if you wanted to keep the badge in the readme, you could alternatively fix the img link as part of the branch/release process, since
https://api.travis-ci.org/bitcoin/bitcoin.svg?branch=0.18and
https://api.travis-ci.org/bitcoin/bitcoin.svg?tag=v0.18.0seem to work as expected
-
naumenkogs commented at 7:48 PM on June 19, 2019: member
ACK
- MarcoFalke merged this on Jun 19, 2019
- MarcoFalke closed this on Jun 19, 2019
- MarcoFalke referenced this in commit 413e438ea9 on Jun 19, 2019
-
kallewoof commented at 3:36 AM on June 20, 2019: member
Post-merge ACK
I understand it's only docs, but 4 hours between opening and merging (author and merger being the same person) sets a bad precedent, IMO.
- MarcoFalke deleted the branch on Jun 20, 2019
- vijaydasmp referenced this in commit 4f6dea602f on Oct 27, 2021
- vijaydasmp referenced this in commit d8195d3f76 on Oct 28, 2021
- vijaydasmp referenced this in commit ed8324179d on Oct 29, 2021
- vijaydasmp referenced this in commit 10190ac0e1 on Oct 30, 2021
- vijaydasmp referenced this in commit b578acb92f on Nov 2, 2021
- vijaydasmp referenced this in commit c70d6396ce on Nov 7, 2021
- vijaydasmp referenced this in commit 7406464f13 on Nov 11, 2021
- vijaydasmp referenced this in commit 49302f7468 on Nov 12, 2021
- vijaydasmp referenced this in commit a1dd9a7855 on Nov 13, 2021
- vijaydasmp referenced this in commit 8ea24f17a2 on Nov 14, 2021
- vijaydasmp referenced this in commit 87a886ad83 on Nov 14, 2021
- vijaydasmp referenced this in commit b9d4dbb12f on Nov 16, 2021
- DrahtBot locked this on Dec 16, 2021