bench: Replace <wallet/crypter.h> with <keystore.h> in src/bench/ccoins_caching.cpp #16303

pull l2a5b1 wants to merge 1 commits into bitcoin:master from l2a5b1:patch/replace_crypter_include changing 1 files +1 −1

l2a5b1 commented at 2:06 PM on June 28, 2019: contributor
This pull request replaces the included <wallet/crypter.h> header in src/bench/ccoins_caching.cpp with <keystore.h> because only the latter is required.

For context see:
- Bitcoin developer notes:
- SF.10 Avoid dependencies on implicitly included names
Every .cpp and .h file should #include every header file it directly uses classes, functions or other definitions from, even if those headers are already included indirectly through other headers.

Avoid surprises. Avoid having to change #includes if an #included header changes. Avoid accidentally becoming dependent on implementation details and logically separate entities included in a header.

Replace <wallet/crypter.h> with <keystore.h>

This commit replaces the included `<wallet/crypter.h>` header
in `src/bench/ccoins_caching.cpp` with `<keystore.h>` because
only the latter is required.

3fec09dfcb

fanquake added the label Tests on Jun 28, 2019
fanquake added the label Refactoring on Jun 28, 2019
MarcoFalke commented at 3:07 PM on June 28, 2019: member
Thanks. This is currently being worked on, so please provide this as feedback in
- Refactor CWallet's inheritance chain #16227
MarcoFalke closed this on Jun 28, 2019
achow101 commented at 3:55 PM on June 28, 2019: member

@l2a5b1 #16227 is refactoring and removing all of the CKeyStore and CBasicKeyStore stuff, including removingkeystore.h entirely. So it can also fix this include at the same time.
l2a5b1 commented at 4:19 PM on June 28, 2019: contributor

@achow101 Thanks!
DrahtBot locked this on Dec 16, 2021

Contributors

Labels