There is a common misconception that the block count returned by the blockchain rpcs includes the genesis block. See for example the discussion in #16292 (comment).
However, it really returns the height, which is 0 for the genesis block.
So clarify that and also remove the misleading "longest blockchain" comment.
Finally, fix the wallet test that incorrectly used this rpc.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
No conflicts as of last run.
However, it really returns the height, which is 0 for the genesis block.
This has always been the case, right? I know of no other block height definition than this.
Yes, this has always been the case afaik. The documentation I am changing here was added in 22f721dbf23cf5ce9e3ded9bcfb65a3894cc0f8c (2010)
ACK fab0c82, sorry for the misconception.
Eh, no worries. I look it up every time to be sure as well.
sorry for the misconception.
Yes, no worries, I kind of missed that the RPC call is called getblockcount and not getblockheight. Block count is definitely ambigious.