The bitcoin-tx utility uses common stdin convention -.
https://github.com/bitcoin/bitcoin/blob/536590f358dc3d3e5821eba7f1009452ea93b205/src/bitcoin-tx.cpp#L793-L796
This PR makes it explicit in the ArgsManager::ParseParameters() function.
Early "-" check for bitcoin-tx using stdin in ParseParameters() #16389
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20190714-short-parse-tx changing 1 files +1 −0-
hebasto commented at 8:30 PM on July 14, 2019: member
-
Early "-" check for bitcoin-tx using stdin 09d671976b
-
promag commented at 9:19 PM on July 14, 2019: member
Is this really necessary? It's already ignored.
-
hebasto commented at 9:38 PM on July 14, 2019: member
It's already ignored.
Yes, it is. At the end of the for-loop body ;)
Is this really necessary?
I found myself digging into the failed
test/util/bitcoin-util-test.pytest on my other PR. I guess this only line of code could save time for other devs. Explicit is better than implicit. - fanquake added the label Utils/log/libs on Jul 14, 2019
- hebasto closed this on Jul 16, 2019
- hebasto deleted the branch on Jul 18, 2019
- DrahtBot locked this on Dec 16, 2021
Labels