qa: Add --filter option to test_runner.py #16390

pull promag wants to merge 1 commits into bitcoin:master from promag:2019-07-testrunner-filter changing 1 files +4 −0

promag commented at 10:25 PM on July 14, 2019: member
Allows to run functional tests like:
```
test/functional/test_runner.py --filter wallet
```
fanquake added the label Tests on Jul 14, 2019
in test/functional/test_runner.py:237 in 3cde06bdac outdated
```
 233 | @@ -234,6 +234,7 @@ def main():
 234 |      parser.add_argument('--quiet', '-q', action='store_true', help='only print dots, results summary and failure logs')
 235 |      parser.add_argument('--tmpdirprefix', '-t', default=tempfile.gettempdir(), help="Root directory for datadirs")
 236 |      parser.add_argument('--failfast', action='store_true', help='stop execution after the first test failure')
 237 | +    parser.add_argument('--filter', help='regular expression to filter scripts to run')
```
jonatack commented at 4:31 PM on July 15, 2019:

Perhaps place it alphabetically, e.g. between extended and help. The failfast placement looks like an anomaly.

Suggested help: "filter tests to run by regular expression", or possibly "filter scripts to run by regular expression", in the format of verb + subject + details.

promag commented at 12:00 AM on July 16, 2019:

Argument --ci is also misplaced. Note that test/functional/test_runner.py --help already has the output sorted.

Updated message.

jonatack commented at 8:51 AM on July 16, 2019:

When I run test/functional/test_runner.py --help on Linux Debian, the output is not sorted (it's a bit of a mess TBH and am writing a PR to improve that and a few other things with the test runner output).
jonatack commented at 4:36 PM on July 15, 2019: member

Concept ACK / tested ACK
qa: Add --filter option to test_runner.py 1a62425260
promag force-pushed on Jul 16, 2019
jonatack commented at 8:55 AM on July 16, 2019: member

ACK 1a6242526093424947eb49f3416dc0c6bc9fc3a8
MarcoFalke merged this on Jul 16, 2019
MarcoFalke closed this on Jul 16, 2019
MarcoFalke referenced this in commit 8f9725c83f on Jul 16, 2019
promag deleted the branch on Jul 16, 2019
jnewbery commented at 1:31 PM on July 16, 2019: member

Just saw this. What's wrong with ./test_runner.py wallet*?
promag commented at 1:36 PM on July 16, 2019: member

Nothing wrong, you have to cd test/functional/ or something like that. This is also similar to bench_bitcoin -filter.
jonatack commented at 1:57 PM on July 16, 2019: member

There is no further need to cd into test/functional/ with #16374. Maybe I should have been more explicit in my review; I saw this PR as an optional complement to that PR but not a replacement.
MarcoFalke commented at 2:35 PM on July 16, 2019: member

See the IRC discussion:

Currently, passing wildcard testname args to the test runner from outside the test/functional/ directory does not work. See these recent IRC discussions for more background: http://www.erisian.com.au/bitcoin-core-dev/log-2019-07-10.html#l-262 (lines 262 to 323) and http://www.erisian.com.au/bitcoin-core-dev/log-2019-07-11.html#l-134.

From #16374#issue-296813072
PastaPastaPasta referenced this in commit 3e5b2f801e on Jun 27, 2021
PastaPastaPasta referenced this in commit df62a4cbea on Jun 28, 2021
PastaPastaPasta referenced this in commit e97a5bdf71 on Jun 29, 2021
PastaPastaPasta referenced this in commit 50ac57a6d1 on Jul 1, 2021
PastaPastaPasta referenced this in commit 8f1cb43c29 on Jul 1, 2021
PastaPastaPasta referenced this in commit 3fdd143b9a on Jul 12, 2021
PastaPastaPasta referenced this in commit 1234cea86a on Jul 13, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels