Always connect NotifyEntryRemoved with MempoolEntryRemoved #16437

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1907-AlwaysNotifyMempoolEntryRemoved changing 4 files +15 −29

MarcoFalke commented at 7:29 PM on July 22, 2019: member

TransactionRemovedFromMempool is used to notify of removed tx, excluding txs that were already notified via BlockConnected. However, we will miss those notifications, if we forgot to call RegisterWithMempoolSignals. This happened in the unit tests (setup_common).

Fix it by enforcing that the connection is always established, which simplifies the code. Also, add some docs.
Always connect NotifyEntryRemoved with MempoolEntryRemoved fa6363500d
MarcoFalke force-pushed on Jul 22, 2019
MarcoFalke added the label Refactoring on Jul 22, 2019
DrahtBot commented at 10:37 PM on July 22, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15606 ([experimental] UTXO snapshots by jamesob)
- #14384 (Resolve validationinterface circular dependencies by l2a5b1)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke commented at 7:33 PM on July 23, 2019: member

Solved in #14384
MarcoFalke closed this on Jul 23, 2019
MarcoFalke deleted the branch on Jul 23, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels