Chunbao
commented at 2:18 PM on July 25, 2019:
none
Pull requests without a rationale and clear improvement may be closed
immediately.
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly.
Any test improvements or new tests that improve coverage are always welcome.
All other changes should have accompanying unit tests (see src/test/) or
functional tests (see test/). Contributors should note which tests cover
modified code. If no tests exist for a region of modified code, new tests
should accompany the change.
Bug fixes are most welcome when they come with steps to reproduce or an
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
Features are welcome, but might be rejected due to design or scope issues.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of Bitcoin Core, if possible.
Refactoring changes are only accepted if they are required for a feature or
bug fix or otherwise improve developer experience significantly. For example,
most "code style" refactoring changes require a thorough explanation why they
are useful, what downsides they have and why they significantly improve
developer experience or avoid serious programming bugs. Note that code style
is often a subjective matter. Unless they are explicitly mentioned to be
preferred in the developer notes, stylistic code
changes are usually rejected.
Bitcoin Core has a thorough review process and even the most trivial change
needs to pass a lot of eyes and requires non-zero or even substantial time
effort to review. There is a huge lack of active reviewers on the project, so
patches often sit for a long time.
Update README.mda4105a1472
msvc gitignore696f2ff1e1
not ignore files about autogen.sh and configurea849eaf1fe
cd depends; make HOST=i686-w64-mingw32b; cd ..; ./autogen.sh (Bash on Ubuntu on Windows)9c2b5b2e88
CONFIG_SITE=$PWD/depends/i686-w64-mingw32/share/config.site ./configure --enable-debug (Bash on Ubuntu on Windows)324d196761
Fix msvc compiler error C4146 (unary minus operator applied to unsigned type)
On msvc14, int literal '-2147483648' is invalid, because '2147483648' is unsigned type and cant't apply minus operator to unsigned type.
To define the int literal, use '-2147483647 - 1' formula that is also used to define INT_MIN in limits.h.
4432ec9e31
Apply NetworkType to test codes3ee7cb9efc
Merge pull request #6 from kobake/unit-test
Unit test project
65430ce985
generated src/test/data/*.json.h by make6ffbae3c72
ToString: ToHexString alias3e6beead9b
Apply NetworkType25e61d50b1
test_bitcoin_fuzzy: Don't depend on unistd0e2cc361f0
test_bitcoin_fuzzy: Don't depend on unistd9ea30650cc
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:15 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me