[qa] Fix race condition in example_test.py #16459

1. 
   sdaftuar commented at 3:30 PM on July 25, 2019: member

   There's a race between sending a getdata for a bunch of blocks with the node receiving those blocks from a peer, which could cause test failure. Fix this.

2. [qa] Fix race condition in example_test.py d9ab0ffa38
3. 
   sdaftuar commented at 3:31 PM on July 25, 2019: member

   Motivated by observing this race caused an appveyor test failure on another PR (https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/26218741).

4. fanquake added the label Tests on Jul 25, 2019
5. 
   MarcoFalke commented at 3:50 PM on July 25, 2019: member

   ACK d9ab0ffa386f2dd8d05852563d5011b3cb501df8

6. MarcoFalke added this to the milestone 0.19.0 on Jul 25, 2019
7. laanwj approved
8. 
   laanwj commented at 4:01 PM on July 25, 2019: member

   ACK d9ab0ffa386f2dd8d05852563d5011b3cb501df8

9. in test/functional/example_test.py:190 in d9ab0ffa38

    185 | @@ -186,12 +186,15 @@ def run_test(self):
    186 |          self.log.info("Connect node2 and node1")
    187 |          connect_nodes(self.nodes[1], 2)
    188 |  
    189 | +        self.log.info("Wait for node2 to receive all the blocks from node1")
    190 | +        self.sync_all()
   

   ---

   ---

   

   promag commented at 4:45 PM on July 25, 2019:

   Could be self.sync_blocks() as the comment implies?

10. 
    promag commented at 4:45 PM on July 25, 2019: member

    ACK d9ab0ffa386f2dd8d05852563d5011b3cb501df8.

11. MarcoFalke referenced this in commit fcc4025c12 on Jul 25, 2019
12. MarcoFalke merged this on Jul 25, 2019
13. MarcoFalke closed this on Jul 25, 2019

    ---

14. 
    jnewbery commented at 5:05 PM on July 25, 2019: member

    Code review ACK d9ab0ffa386f2dd8d05852563d5011b3cb501df8.

    Good catch!

15. codablock referenced this in commit 72ab7bb703 on Apr 7, 2020
16. codablock referenced this in commit f7405bfb52 on Apr 8, 2020
17. codablock referenced this in commit 62dc0bbdae on Apr 8, 2020
18. jasonbcox referenced this in commit b8eaec1a70 on Oct 12, 2020
19. ckti referenced this in commit 5f26783bd8 on Mar 28, 2021
20. DrahtBot locked this on Dec 16, 2021

Milestone
0.19.0