bumpfee.TotalFee removed without replacement #16485

1. 
   MarcoFalke commented at 1:46 PM on July 29, 2019: member

   #15996 (comment)

2. MarcoFalke added the label Wallet on Jul 29, 2019
3. MarcoFalke added the label RPC/REST/ZMQ on Jul 29, 2019
4. MarcoFalke added this to the milestone 0.19.0 on Jul 29, 2019
5. 
   instagibbs commented at 1:55 PM on July 29, 2019: member

   confTarget? Or you mean more like #16203 ?

   If we think it's a mistake to remove a feature, then it shouldn't matter if there's a direct feerate replacement anyways, and it should be reverted.

6. 
   instagibbs commented at 1:59 PM on July 29, 2019: member

   Probably the best point in favor of not removing it: #15996 (comment)

   to which I responded essentially "power users don't need that RPC call at all if they're manually calculating package rates"

7. 
   MarcoFalke commented at 3:27 PM on July 29, 2019: member

   Probably the best point in favor of not removing it: #15996 (comment)

   This overlaps a bit with

   • Implement auto-fee leveling when spending unconfirmed outputs #15553

   I'd say it can be solved by an optional flag, that indicates if the target fee rate should be for the tx that is bumped or for the package

8. 
   Sjors commented at 8:39 AM on August 2, 2019: member

   I'm fine with removing totalFee once feeRate is there, see #16203.

   Note that totalFee is deprecated, but not removed. Though I agree it's also odd to deprecate something before there's a replacement.

9. 
   MarcoFalke commented at 12:24 PM on August 2, 2019: member

   At the very least it should be possible to switch back and forth between two major releases without having to re-adjust the API every time. Deprecating something without replacement is breaking that.

10. 
    instagibbs commented at 8:23 PM on August 6, 2019: member

    I'll try to push to get #16492 in master then to avoid any issues or need for reversion.

11. 
    instagibbs commented at 6:48 PM on September 13, 2019: member

    #16727 is pretty much sitting there waiting for more review. Probably a little late for feature freeze, maybe not though? Might be able to get the band together to squeeze it in.

12. 
    instagibbs commented at 1:59 PM on October 2, 2019: member

    This has been resolved by #16727 which is now merged

13. MarcoFalke closed this on Oct 2, 2019

    ---

14. MarcoFalke locked this on Dec 16, 2021

Milestone
0.19.0