small UX update for optionsdialog #1649

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:optionsdialog changing 3 files +23 −12

Diapolo commented at 7:07 AM on August 2, 2012: none
- add enableApplyButton() and disableApplyButton() to optionsdialog.{h/cpp}
- they are used to ensure the Ok button does not get disabled, when Apply needs to be disabled (standard UX should allow Ok always to dismiss the dialog and only disable it, when we have a faulty proxy IP)
- disable Apply after initially loading the settings, as nothing new needs to be saved
- remove orphan settings from optionsdialog.ui that are default anyway

small UX update for optionsdialog

- add enableApplyButton() and disableApplyButton() to optionsdialog.{h/cpp}
- they are used to ensure the Ok button does not get disabled, when Apply needs to be disabled (standard UX should allow Ok always to dismiss the dialog and only disable it, when we have a faulty proxy IP)
- disable Apply after initially loading the settings, as nothing new needs to be saved
- remove orphan settings from optionsdialog.ui that are default anyway

4aaa4313e7

in src/qt/optionsdialog.cpp:None in 4aaa4313e7
```
 149 | @@ -147,6 +150,16 @@ void OptionsDialog::setMapper()
 150 |      mapper->addMapping(ui->displayAddresses, OptionsModel::DisplayAddresses);
 151 |  }
 152 |  
 153 | +void OptionsDialog::enableApplyButton()
 154 | +{
```
laanwj commented at 7:10 AM on August 2, 2012:

Why define a function (two functions, even) for what is one (pretty straightforward) line anyway? Or do you plan to extend this?

Diapolo commented at 7:14 AM on August 2, 2012:

It is used in connect(mapper, SIGNAL(viewModified()), this, SLOT(enableApplyButton()));, where I can't use ui->applyButton->setEnabled(true); directly, right?

laanwj commented at 7:29 AM on August 2, 2012:

You're right. It sucks that connect(mapper, SIGNAL(viewModified()), ui, SLOT(setEnabled(true))); is not possible.

Diapolo commented at 8:39 PM on August 13, 2012:

So everything fine here :)?
BitcoinPullTester commented at 11:55 AM on August 8, 2012: none

The following is an automatic comment from the Bitcoin Pull Tester. If you believe it is in error, please contact jenkins@bluematt.me

This pull passed automatic sanity-tests! This means it merges cleanly onto current master, builds and unit-tests pass You can find the test log and build output at http://jenkins.bluematt.me/pull-tester/4aaa4313e7edf5d23143e393efd2d5892d5dde48
laanwj closed this on Aug 14, 2012
laanwj referenced this in commit 0825aee8f4 on Aug 14, 2012
laanwj merged this on Aug 14, 2012
suprnurd referenced this in commit 7efa5e79d7 on Dec 5, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester