wallet: Drop support to serialize OldKey #16494

pull promag wants to merge 2 commits into bitcoin:master from promag:2019-07-drop-oldkey-serialize changing 2 files +17 −22

promag commented at 4:11 PM on July 30, 2019: member

Follow up #16475, removes support to serialize OldKey. Attempting to serialize OldKey results in compilation error.
wallet: Drop support to serialize OldKey 6df41644cf
jnewbery commented at 4:20 PM on July 30, 2019: member

concept ACK

What are your thoughts about moving OldKey to walletdb.h now that it's only used for deserialization? (there's precedence - CHDChain and CKeyMetadata are defined in that file)
laanwj added the label Wallet on Jul 30, 2019
wallet: Move OldKey to walletdb.h d7855d0a44
promag commented at 4:28 PM on July 30, 2019: member

@jnewbery done, it could be moved to walletdb.cpp if you prefer.
jnewbery commented at 5:56 PM on July 30, 2019: member

utACK d7855d0a4

it could be moved to walletdb.cpp if you prefer.

Yes, it probably makes more sense in walletdb.cpp since it's not used outside of walletdb.
jonasschnelli commented at 6:09 PM on July 30, 2019: contributor

Nice cleanup. I kinda dislike the name "OldKey" (I should have raised that concern in #16475 though). The term "Old" in software-code, is a very much dynamic and should IMO be avoided. It's unclear to the reader what "Old" means and what an "old wallet" exactly is. Ideally we would have a bit more information like since what version we stopped writing such keys, etc.

utACK d7855d0a445ea0d82bd22252876496250be7cd8e
MarcoFalke commented at 6:24 PM on July 30, 2019: member

I think this has been added in 0.2.2 or 0.3.1, but never used substantially? So I am not sure when it got removed.

53d508072b02d522371bde148dcc3e925f472be7

2939cab06d65548abdaeb1ff218550eb47b93362
achow101 commented at 7:20 PM on July 30, 2019: member

AFAICT, we never had any code that wrote a wkey record ever. So I think this can be removed entirely.
sipa commented at 7:42 PM on July 30, 2019: member

Seems indeed that read support for "wkey" was added in 0.2.2, but never any code that writes it.
jnewbery commented at 8:06 PM on July 30, 2019: member

I can't find anywhere in the git history where this was written. Agree that we can remove this entirely.

If Satoshi still has some keys saved as wkeys in an old wallet.dat file, they can be opened with v0.18 or earlier.
promag commented at 9:54 PM on July 30, 2019: member

Replaced by #16502.
promag closed this on Jul 30, 2019
promag deleted the branch on Jul 30, 2019
fanquake referenced this in commit b7fbf74b98 on Aug 1, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16475 wallet: Enumerate walletdb keys #16502 wallet: Drop unused OldKey