A: Chainparams: Rename RequireStandard() to DefaultAcceptNonstd() #16526

1. 
   jtimon commented at 10:19 pm on August 1, 2019: contributor

   Alternative to #16527

   Just a rename, shouldn’t change functionality. Can be considered bik-shedding, but I believe the resulting code is more clear, less negations.

   Rename related to #16770

2. fanquake added the label Refactoring on Aug 1, 2019
3. 
   DrahtBot commented at 11:34 pm on August 1, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17037 (Testschains: Many regtests with different genesis and default datadir by jtimon)
   • #17032 (Tests: Chainparams: Make regtest almost fully customizable by jtimon)
   • #16770 (Chainparams: Rename IsTestChain() to AllowAcceptNonstd() by jtimon)
   • #16527 (B: Get rid of Params().RequireStandard() by jtimon)
   • #8994 (Testchains: Introduce custom chain whose constructor… by jtimon)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. jtimon renamed this:
   Refactor: Chainparams: readability
   A: Refactor: Chainparams: readability
   on Aug 1, 2019
5. DrahtBot added the label Needs rebase on Aug 2, 2019
6. jtimon force-pushed on Aug 7, 2019
7. 
   jtimon commented at 2:46 am on August 7, 2019: contributor

   Rebased
8. DrahtBot removed the label Needs rebase on Aug 7, 2019
9. jtimon force-pushed on Aug 7, 2019
10. Chainparams: Rename RequireStandard() to DefaultAcceptNonstd() 3094a33034
11. jtimon force-pushed on Aug 31, 2019
12. 
    jtimon commented at 4:35 pm on August 31, 2019: contributor

    Decoupled from #16524
13. jtimon renamed this:
    A: Refactor: Chainparams: readability
    A: Chainparams: Rename RequireStandard() to DefaultAcceptNonstd()
    on Aug 31, 2019
14. 
    luke-jr commented at 11:03 pm on October 8, 2019: member

    Don’t think this is worth it.
15. 
    jtimon commented at 1:42 pm on October 9, 2019: contributor

    Since I seem to be alone in considering:

    0    fRequireStandard = !gArgs.GetBoolArg("-acceptnonstdtxn", chainparams.DefaultAcceptNonstd());
    

    much more readable than

    0    fRequireStandard = !gArgs.GetBoolArg("-acceptnonstdtxn", !chainparams.RequireStandard());
    

    just by having one less negation…closing

16. jtimon closed this on Oct 9, 2019

    ---

17. 
    MarcoFalke commented at 2:23 pm on October 9, 2019: member

    I like it, but yeah shrug
18. DrahtBot locked this on Dec 16, 2021

Contributors
jtimon DrahtBot luke-jr MarcoFalke

Labels
Refactoring