Alternative to #16527
Just a rename, shouldn't change functionality. Can be considered bik-shedding, but I believe the resulting code is more clear, less negations.
Rename related to #16770
A: Chainparams: Rename RequireStandard() to DefaultAcceptNonstd() #16526
pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:b19-chainparams-no-istestchain changing 3 files +8 −9-
jtimon commented at 10:19 PM on August 1, 2019: contributor
- fanquake added the label Refactoring on Aug 1, 2019
-
DrahtBot commented at 11:34 PM on August 1, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #17037 (Testschains: Many regtests with different genesis and default datadir by jtimon)
- #17032 (Tests: Chainparams: Make regtest almost fully customizable by jtimon)
- #16770 (Chainparams: Rename IsTestChain() to AllowAcceptNonstd() by jtimon)
- #16527 (B: Get rid of Params().RequireStandard() by jtimon)
- #8994 (Testchains: Introduce custom chain whose constructor... by jtimon)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- jtimon renamed this:
Refactor: Chainparams: readability
A: Refactor: Chainparams: readability
on Aug 1, 2019 - DrahtBot added the label Needs rebase on Aug 2, 2019
- jtimon force-pushed on Aug 7, 2019
-
jtimon commented at 2:46 AM on August 7, 2019: contributor
Rebased
- DrahtBot removed the label Needs rebase on Aug 7, 2019
- jtimon force-pushed on Aug 7, 2019
-
Chainparams: Rename RequireStandard() to DefaultAcceptNonstd() 3094a33034
- jtimon force-pushed on Aug 31, 2019
-
- jtimon renamed this:
A: Refactor: Chainparams: readability
A: Chainparams: Rename RequireStandard() to DefaultAcceptNonstd()
on Aug 31, 2019 -
luke-jr commented at 11:03 PM on October 8, 2019: member
Don't think this is worth it.
-
jtimon commented at 1:42 PM on October 9, 2019: contributor
Since I seem to be alone in considering:
fRequireStandard = !gArgs.GetBoolArg("-acceptnonstdtxn", chainparams.DefaultAcceptNonstd());much more readable than
fRequireStandard = !gArgs.GetBoolArg("-acceptnonstdtxn", !chainparams.RequireStandard());just by having one less negation...closing
- jtimon closed this on Oct 9, 2019
-
MarcoFalke commented at 2:23 PM on October 9, 2019: member
I like it, but yeah shrug
- DrahtBot locked this on Dec 16, 2021
