doc: mention whitelist is inbound, and applies to blocksonly #16555

1. 
   Sjors commented at 10:50 am on August 6, 2019: member

   • -whitelist only impacts inbound nodes (see #9923). This is obvious in the context of allowing those nodes to connect to you, but there are additional whitelist features where this is less obvious, such as mempool relay behavior.

   • whitelistrelay (on by default) explains that -blocksonly makes an exception for transactions from whitelisted nodes, but it wasn’t documented (nor obvious imo) the other way around. See also #15984 (comment)

2. laanwj added the label Docs on Aug 6, 2019
3. MarcoFalke added this to the milestone 0.19.0 on Aug 6, 2019
4. in src/init.cpp:366 in d00498d83f outdated

   362@@ -363,7 +363,7 @@ void SetupServerArgs()
   363     gArgs.AddArg("-blocknotify=<cmd>", "Execute command when the best block changes (%s in cmd is replaced by block hash)", ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
   364 #endif
   365     gArgs.AddArg("-blockreconstructionextratxn=<n>", strprintf("Extra transactions to keep in memory for compact block reconstructions (default: %u)", DEFAULT_BLOCK_RECONSTRUCTION_EXTRA_TXN), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
   366-    gArgs.AddArg("-blocksonly", strprintf("Whether to reject transactions from network peers. Transactions from the wallet or RPC are not affected. (default: %u)", DEFAULT_BLOCKSONLY), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
   367+    gArgs.AddArg("-blocksonly", strprintf("Whether to reject transactions from network peers. Transactions from the wallet, RPC and whitelisted inbound peers are not affected. (default: %u)", DEFAULT_BLOCKSONLY), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
   

   ---

   ---

   

   MarcoFalke commented at 1:52 pm on August 6, 2019:

   whitelistrelay must be on as well for it to work.

   At some point, I think we should explain parameter interaction in a document and not in the per-option help text

   ---

   

   Sjors commented at 3:00 pm on August 6, 2019:

   As long as whitelistrelay is on by default I don’t think that needs mentioning. With #16248 we can reword this to “relay whitelisted”.

   ---

   

   Sjors commented at 11:55 am on August 15, 2019:

   Rebased and reworded to “relay whitelisted”.
5. Sjors force-pushed on Aug 15, 2019
6. 
   DrahtBot commented at 5:50 am on August 16, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #16629 (doc: Add documentation for the new whitelist permissions by NicolasDorier)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   NicolasDorier commented at 8:21 am on August 16, 2019: contributor

   Concept ACK, will rebase my PR later on this one.
8. 
   NicolasDorier commented at 8:40 am on August 16, 2019: contributor

   Btw, I just saw thanks to this PR that the default of whitelistrelay is true, while I made it false in #16248 . Making a fix.
9. 
   NicolasDorier commented at 8:50 am on August 16, 2019: contributor

   https://github.com/bitcoin/bitcoin/pull/16631
10. [doc] mention whitelist is inbound, and applies to blocksonly 20ea9ef6ce
11. Sjors force-pushed on Aug 16, 2019
12. 
    Sjors commented at 1:59 pm on August 16, 2019: member

    @NicolasDorier glad you caught that. Rebased for Travis fix.
13. 
    NicolasDorier commented at 9:26 am on August 19, 2019: contributor

    ACK, will add documentation about the permissions flag after this one get merged.
14. fanquake renamed this:
    [doc] mention whitelist is inbound, and applies to blocksonly
    doc: mention whitelist is inbound, and applies to blocksonly
    on Aug 19, 2019
15. MarcoFalke referenced this in commit 1d74693e8a on Aug 19, 2019
16. MarcoFalke merged this on Aug 19, 2019
17. MarcoFalke closed this on Aug 19, 2019

    ---

18. Sjors deleted the branch on Aug 19, 2019
19. sidhujag referenced this in commit 84228bdcc4 on Aug 19, 2019
20. deadalnix referenced this in commit 1118027f79 on Oct 19, 2020
21. zkbot referenced this in commit ba4eb241e7 on Mar 31, 2021
22. vijaydasmp referenced this in commit df0665137e on Oct 27, 2021
23. vijaydasmp referenced this in commit 2e8b792965 on Oct 28, 2021
24. vijaydasmp referenced this in commit 7b75d5c9df on Oct 29, 2021
25. vijaydasmp referenced this in commit b113e72ecc on Oct 30, 2021
26. vijaydasmp referenced this in commit 53f792edd1 on Nov 2, 2021
27. vijaydasmp referenced this in commit 514c0bf08b on Nov 7, 2021
28. vijaydasmp referenced this in commit 221e4769e8 on Nov 11, 2021
29. vijaydasmp referenced this in commit 757494e339 on Nov 12, 2021
30. vijaydasmp referenced this in commit 4e4e417ed2 on Nov 13, 2021
31. vijaydasmp referenced this in commit 85a8810b69 on Nov 14, 2021
32. vijaydasmp referenced this in commit 313a4606a6 on Nov 14, 2021
33. vijaydasmp referenced this in commit 52a577891e on Nov 16, 2021
34. DrahtBot locked this on Dec 16, 2021

Contributors
Sjors MarcoFalke DrahtBot NicolasDorier

Labels
Docs

Milestone
0.19.0