Because operators are implemented in the base class, and being inherited by uint256 and unit512, if a copy or read is made between these types, random memory would be being accessed.
[validation] static_assert to ensure width in unit class #16679
pull shargon wants to merge 3 commits into bitcoin:master from shargon:fix-unit-base changing 1 files +8 −0-
shargon commented at 10:43 AM on August 22, 2019: none
-
static_assert to ensure width in unit class 6bb970d214
-
9e3ae4e690
static_assert to ensure width in unit class
Remove trailing white spaces
-
Merge remote-tracking branch 'origin/fix-unit-base' into fix-unit-base f5df0c5882
-
instagibbs commented at 1:57 PM on August 23, 2019: member
linter is complaining whitespace:
diff --git a/src/arith_uint256.h b/src/arith_uint256.h @@ -111,0 +116,2 @@ public: + @@ -135,0 +142,2 @@ public: + ^---- failure generated from test/lint/lint-whitespace.sh -
shargon commented at 3:01 PM on August 23, 2019: none
I see, but what spaces? 😕
-
MarcoFalke commented at 3:08 PM on August 23, 2019: member
Our ci did not run on this pull request. Anyway, looks like those three commits should be a single one. Could you rebase and/or squash those into one?
-
shargon commented at 3:25 PM on August 23, 2019: none
Closed in favor of https://github.com/bitcoin/bitcoin/pull/16696
- shargon closed this on Aug 23, 2019
- shargon deleted the branch on Aug 23, 2019
- MarcoFalke locked this on Dec 16, 2021
Contributors