Fix missing destructor in class #16686

pull BlockMechanic wants to merge 1 commits into bitcoin:master from BlockMechanic:master changing 1 files +2 −0

BlockMechanic commented at 8:24 PM on August 22, 2019: contributor

Fixes missing destructor in abstract class CBlockHeader. Not an error but introduces annoying warnings if compiling with clang.

Issue reported here:- https://github.com/bitcoin/bitcoin/issues/16685

Fix missing destructor in class

Fixes missing destructor in abstract class CBlockHeader. Not an error but introduces annoying warnings if compiling with clang.

7d8f0e8fa5

hebasto commented at 6:27 AM on August 23, 2019: member

@BlockMechanic

Fixes missing destructor in abstract class CBlockHeader.

The CBlockHeader is not an abstract class.

But it is a base class from which the CBlock class is derived: https://github.com/bitcoin/bitcoin/blob/43eaf76e02679408ee43489b3961f845a9eb3f7f/src/primitives/block.h#L72

Not an error but introduces annoying warnings if compiling with clang.

Could be an UB.

https://en.cppreference.com/w/cpp/language/destructor:

Deleting an object through pointer to base invokes undefined behavior unless the destructor in the base class is virtual.

The bottom line: @BlockMechanic could you update the PR description?
DrahtBot commented at 5:40 AM on August 24, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16539 (wallet: lower -txmaxfee default from 0.1 to 0.01 BTC by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
BlockMechanic commented at 9:42 AM on August 24, 2019: contributor

Nope, withdrawn. was resolved after i figured out a cxx flag issue. Thanks !
BlockMechanic closed this on Aug 24, 2019
DrahtBot locked this on Dec 16, 2021

Contributors