test: Establish only one connection between nodes in rpc_invalidateblock #16737

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1908-testConnectOnce changing 1 files +3 −3

MarcoFalke commented at 7:29 PM on August 27, 2019: member

Headers and block sync should eventually converge to the same result, regardless of whether the peers treat each other as "inbound" or "outbound".

connect_nodes_bi has been introduced as a (temporary?) workaround for bug #5113 and #5138, which has long been fixed in #5157 and #5662.

Thus remove the connect_nodes_bi workaround from the rpc_invalidateblock test.

Conveniently, this also closes #16453. See #16444 (comment) for rationale
test: Establish only one connection between nodes in rpc_invalidateblock fae961de6b
DrahtBot added the label Tests on Aug 27, 2019
laanwj commented at 11:44 AM on September 16, 2019: member

ACK fae961de6be3e2ab9793d437079651541e219e71
laanwj referenced this in commit cd737214ce on Sep 16, 2019
laanwj merged this on Sep 16, 2019
laanwj closed this on Sep 16, 2019
MarcoFalke deleted the branch on Sep 16, 2019
sidhujag referenced this in commit f9a3ff0065 on Sep 16, 2019
vijaydasmp referenced this in commit c1060026d1 on Dec 6, 2021
vijaydasmp referenced this in commit 63b39a1f65 on Dec 10, 2021
vijaydasmp referenced this in commit 68a010f4ff on Dec 13, 2021
vijaydasmp referenced this in commit 3bc73a2abf on Dec 13, 2021
vijaydasmp referenced this in commit bff9273316 on Dec 15, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels