qa: Relax so that the subscriber is ready before publishing zmq messages #16740

pull promag wants to merge 1 commits into bitcoin:master from promag:2019-08-slowjoiner changing 1 files +7 −2

promag commented at 10:36 PM on August 27, 2019: member

Prevents the syndrome "slow joiner" - see http://zguide.zeromq.org/py:all#sockets-and-patterns - by relaxing before publishing messages.
promag commented at 10:37 PM on August 27, 2019: member

Follow up to #16404 (comment).
fanquake added the label Tests on Aug 27, 2019
qa: Relax so that the subscriber is ready before publishing zmq messages 403e372407

in test/functional/interface_zmq.py:76 in fc921f3f5a outdated

  70 | @@ -71,6 +71,9 @@ def test_basic(self):
  71 |  
  72 |          self.restart_node(0, ["-zmqpub%s=%s" % (sub.topic.decode(), address) for sub in [hashblock, hashtx, rawblock, rawtx]])
  73 |          connect_nodes(self.nodes[0], 1)
  74 | +        socket.connect(address)
  75 | +        # Relax so that the subscriber is ready before publishing zmq messages
  76 | +        sleep(1)

MarcoFalke commented at 11:21 PM on August 27, 2019:

.2 should be enough or is anything else in here async that asks for a longer sleep?

promag commented at 11:37 PM on August 27, 2019:

I don't think so, I'll lower it.

promag commented at 11:45 PM on August 27, 2019:

Done.

promag force-pushed on Aug 27, 2019
MarcoFalke commented at 11:14 AM on August 28, 2019: member

unsigned ACK 403e372407db1d020eedede4d322ee79d4a85dfc
emilengler commented at 1:55 PM on August 28, 2019: contributor

concept ACK but I would prefer a smaller amount than 0.2 because humans can detegt a delay there. 0.02 would be better I think
MarcoFalke commented at 5:30 PM on August 28, 2019: member

@emilengler The functional tests have nothing to do with a user interface.
MarcoFalke referenced this in commit 119e97ae2d on Aug 28, 2019
MarcoFalke merged this on Aug 28, 2019
MarcoFalke closed this on Aug 28, 2019
promag deleted the branch on Aug 28, 2019
promag commented at 5:35 PM on August 28, 2019: member

@MarcoFalke let me know if you see the test fail again.
jasonbcox referenced this in commit ce6847916a on Sep 3, 2020
jasonbcox referenced this in commit 14653a00bd on Sep 3, 2020
dongcarl commented at 6:17 PM on December 19, 2020: member

@promag is this error the one that is supposed to be fixed by this? https://cirrus-ci.com/task/4605167582576640?command=ci#L4905
MarcoFalke commented at 6:19 PM on December 19, 2020: member

@dongcarl See

#20618 #20590 #20538
UdjinM6 referenced this in commit f5294f6374 on Dec 19, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels