wallet: Translate all initErrors in CreateWalletFromFile #16745

1. 
   MarcoFalke commented at 7:58 PM on August 28, 2019: member

   The translations are going to close in three days (#15940), so I am submitting this as a standalone pull request.

   Those changes are part of a bugfix #16661, which includes a test. The first change (the refactor) is required, the second commit is not. I am happy to drop it, if needed.

2. util: Make util/error bilingual_str (refactor)

   Translated strings should not end up in the debug log, stderr, or
   returned by an RPC.
   
   Changing the util methods in util/error to return a bilingual_str paves
   the way to achieve this goal in the long term.

   fa70d199d0
3. wallet: Translate all initErrors in CreateWalletFromFile

   Every warning or error in this method is translated, except for those
   two. Translate them as well for consistency.

   fa61365a13
4. MarcoFalke added the label Wallet on Aug 28, 2019
5. MarcoFalke added the label GUI on Aug 28, 2019
6. MarcoFalke removed the label GUI on Aug 28, 2019
7. MarcoFalke added this to the milestone 0.19.0 on Aug 28, 2019
8. 
   DrahtBot commented at 10:33 PM on August 28, 2019: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #16771 (Chainparams: Wallet: Decouple DefaultFallbackfee() from IsTestChain() by jtimon)
   • #16661 (wallet: Fix segfault in CreateWalletFromFile, Pass error to rpc caller by MarcoFalke)
   • #16224 (gui: Bilingual GUI error messages by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. 
   hebasto commented at 8:30 AM on August 29, 2019: member

   Concept ACK. Will review in details tonight.

10. hebasto approved
11. 
    hebasto commented at 7:30 AM on August 31, 2019: member

    ACK fa61365a1368f9970fa22fb96f89f4ecc08e69f0, I have tested the code on Linux Mint 19.2.

12. 
    laanwj commented at 2:23 PM on September 3, 2019: member

    utACK fa61365a1368f9970fa22fb96f89f4ecc08e69f0

13. laanwj referenced this in commit 6e431296da on Sep 3, 2019
14. laanwj merged this on Sep 3, 2019
15. laanwj closed this on Sep 3, 2019

    ---

16. MarcoFalke deleted the branch on Sep 3, 2019
17. 
    promag commented at 2:30 PM on September 3, 2019: member

    ACK fa61365a1368f9970fa22fb96f89f4ecc08e69f0.

18. sidhujag referenced this in commit f32507a747 on Sep 3, 2019
19. deadalnix referenced this in commit 78c5f12b9f on Jul 28, 2020
20. MarcoFalke locked this on Dec 16, 2021

Milestone
0.19.0