spurious `Synchronizing blockheaders` log messages on node catching up #16773

1. 
   laanwj commented at 6:18 PM on August 31, 2019: member

   I get a lot of spurious messages like this in the log:

   2019-08-31T18:07:53Z Synchronizing blockheaders, height: 592633 (~100.00%)
   2019-08-31T18:09:40Z Synchronizing blockheaders, height: 592634 (~100.00%)
   2019-08-31T18:09:40Z Synchronizing blockheaders, height: 592634 (~100.00%)
   2019-08-31T18:09:40Z Synchronizing blockheaders, height: 592634 (~100.00%)
   2019-08-31T18:09:40Z Synchronizing blockheaders, height: 592634 (~100.00%)
   2019-08-31T18:09:40Z Synchronizing blockheaders, height: 592634 (~100.00%)
   2019-08-31T18:10:28Z Synchronizing blockheaders, height: 592635 (~100.00%)
   2019-08-31T18:10:28Z Synchronizing blockheaders, height: 592635 (~100.00%)
   2019-08-31T18:10:28Z Synchronizing blockheaders, height: 592635 (~100.00%)
   2019-08-31T18:10:28Z Synchronizing blockheaders, height: 592635 (~100.00%)
   2019-08-31T18:10:28Z Synchronizing blockheaders, height: 592635 (~100.00%)
   2019-08-31T18:11:01Z Synchronizing blockheaders, height: 592636 (~100.00%)
   2019-08-31T18:11:01Z Synchronizing blockheaders, height: 592636 (~100.00%)
   2019-08-31T18:11:01Z Synchronizing blockheaders, height: 592636 (~100.00%)
   2019-08-31T18:11:01Z Synchronizing blockheaders, height: 592636 (~100.00%)
   2019-08-31T18:11:01Z Synchronizing blockheaders, height: 592636 (~100.00%)
   

   also

   2019-08-31T18:19:47Z New outbound peer connected: version: 70015, blocks=592636, peer=0
   2019-08-31T18:19:47Z Synchronizing blockheaders, height: 592636 (~100.00%)
   2019-08-31T18:19:47Z New outbound peer connected: version: 70015, blocks=592636, peer=1
   2019-08-31T18:19:48Z Synchronizing blockheaders, height: 592636 (~100.00%)
   2019-08-31T18:19:48Z New outbound peer connected: version: 70015, blocks=592636, peer=2
   2019-08-31T18:19:49Z Synchronizing blockheaders, height: 592636 (~100.00%)
   

   This log message was introduced in #15615 by @jonasschnelli.. From what I understand, it's supposed to only be shown once per 2000 blocks, not multiple times for the same block.

2. laanwj added the label Utils/log/libs on Aug 31, 2019
3. laanwj added this to the milestone 0.19.0 on Aug 31, 2019
4. laanwj added the label Bug on Aug 31, 2019
5. 
   jonasschnelli commented at 7:40 PM on August 31, 2019: contributor

   I'll look into it.

6. MarcoFalke closed this on Sep 3, 2019

   ---

7. sidhujag referenced this in commit b3459434c9 on Sep 3, 2019
8. humbleDasher referenced this in commit 2996f593ef on Nov 13, 2021
9. pravblockc referenced this in commit 0b4f279949 on Nov 18, 2021
10. MarcoFalke locked this on Dec 16, 2021

Milestone
0.19.0