Update headers and copyright_header.py script #16789

pull GChuf wants to merge 2 commits into bitcoin:master from GChuf:headers changing 277 files +278 −278
  1. GChuf commented at 2:42 pm on September 2, 2019: contributor

    First commit adds .sh and .bash-completion files into the script, which were otherwise left out.

    Second commit updates headers with the script.

    NOTE: The script does not update any *.c or *.cc files although it’s searching for them. .c and .cc files are present in the “excluded directories”. My suggestion would be to either exclude these files from the search, or include the directories. Since I’m not sure what was the exact reasoning, I didn’t change anything.

    some script code:

    INCLUDE = ['*.h', '*.cpp', '*.cc', '*.c', '*.mm', '*.py', '*.sh', '*.bash-completion'] (should I shorten “bash-completion”? the script is slow)

    0EXCLUDE_DIRS = [
    1    # git subtrees
    2    "src/crypto/ctaes/",
    3    "src/leveldb/",
    4    "src/secp256k1/",
    5    "src/univalue/",
    6]
    
  2. DrahtBot added the label Consensus on Sep 2, 2019
  3. DrahtBot added the label GUI on Sep 2, 2019
  4. DrahtBot added the label Mempool on Sep 2, 2019
  5. DrahtBot added the label Mining on Sep 2, 2019
  6. DrahtBot added the label P2P on Sep 2, 2019
  7. DrahtBot added the label RPC/REST/ZMQ on Sep 2, 2019
  8. DrahtBot added the label Scripts and tools on Sep 2, 2019
  9. DrahtBot added the label Tests on Sep 2, 2019
  10. DrahtBot added the label TX fees and policy on Sep 2, 2019
  11. DrahtBot added the label Utils/log/libs on Sep 2, 2019
  12. DrahtBot added the label UTXO Db and Indexes on Sep 2, 2019
  13. DrahtBot added the label Validation on Sep 2, 2019
  14. DrahtBot added the label Wallet on Sep 2, 2019
  15. scripts: update copyright_header script to include additional files
    Include .sh and .bash-completion files as well
    3b4d484dfb
  16. DrahtBot commented at 4:25 pm on September 2, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16341 (Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  17. Update headers bee7b3dda1
  18. emilengler commented at 6:28 pm on September 2, 2019: contributor
    Concept NACK, I think it would be better to do this at the end of December
  19. fanquake closed this on Sep 2, 2019

  20. MarcoFalke commented at 12:59 pm on September 4, 2019: member
    ACK, I think it is fine to do this before every major release.
  21. GChuf commented at 6:44 pm on September 5, 2019: contributor
    Like MarcoFalke said, I did this because a major release is comming soon. And I’ve also updated the script.
  22. emilengler commented at 7:16 pm on September 5, 2019: contributor
    Even though this should be done really shortly before the release like the last commit before the version bump
  23. GChuf commented at 11:17 pm on September 5, 2019: contributor
    @emilengler regarding the timing, I don’t see how that would change anything - what is the reasoning behind that? What I am thinking is, the end result is the same.
  24. emilengler commented at 12:07 pm on September 6, 2019: contributor
    There will be bug fixes as well before the final freeze. If some files are changed again we would need to do this again
  25. emilengler commented at 12:08 pm on September 6, 2019: contributor
    @laanwj Could you run this script in the version bump commit when the time occurs
  26. GChuf commented at 12:14 pm on September 6, 2019: contributor
    I imagine the headers would stay untouched when bug fixes happen - noone would be changing them back from 2019 to 2018 or something similar - is that not true? Am I missing something?
  27. GChuf deleted the branch on Oct 9, 2019
  28. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me