depends: zlib: Move toolchain options to configure #16809

pull dongcarl wants to merge 1 commits into bitcoin:master from dongcarl:2019-09-improve-zlib-pkg changing 1 files +12 −9

dongcarl commented at 6:39 pm on September 5, 2019: member
0zlib has its own custom configure script, see comment in zlib.mk for 1more details
Performed Guix cross-builds locally and everything worked as expected.

depends: zlib: Move toolchain options to configure

zlib has its own custom configure script, see comment in zlib.mk for
more details

f0636d3418

dongcarl added the label Build system on Sep 5, 2019
dongcarl added the label Needs gitian build on Sep 5, 2019
DrahtBot commented at 8:09 pm on September 6, 2019: member
Gitian builds for commit 5e202382a987351a59d5cda98ea9f2aee99f61a5 (master):
- db7528c50896fbc44e13e5bdbb9e0238... bitcoin-0.18.99-aarch64-linux-gnu-debug.tar.gz
- a03660483ed3f38f0d36766750a9280f... bitcoin-0.18.99-aarch64-linux-gnu.tar.gz
- 3cd3ac539ad7fe2443de34453fddae4c... bitcoin-0.18.99-arm-linux-gnueabihf-debug.tar.gz
- 700cb8e369579d5618823767e1a80646... bitcoin-0.18.99-arm-linux-gnueabihf.tar.gz
- 9e463f0ac101fbbf7fb962d721e62483... bitcoin-0.18.99-i686-pc-linux-gnu-debug.tar.gz
- 4dd954effa4cb40cbd07e52fd1f372b1... bitcoin-0.18.99-i686-pc-linux-gnu.tar.gz
- 542489150d8745cfe924211237de7a3b... bitcoin-0.18.99-osx-unsigned.dmg
- 98c97aa2af9dccaa665ed1074764f2ee... bitcoin-0.18.99-osx64.tar.gz
- 659672dc3cf4ac7e54fe38ccbb323aea... bitcoin-0.18.99-riscv64-linux-gnu-debug.tar.gz
- 6072df0b61c6e043b069e5c11ee3edeb... bitcoin-0.18.99-riscv64-linux-gnu.tar.gz
- 32b91937b0c3e432ed992bfcf7ace5fd... bitcoin-0.18.99-win64-debug.zip
- 12f848beb0c902d24f50e2dd59c129de... bitcoin-0.18.99-win64-setup-unsigned.exe
- d53cac1b3017bb96bbd3222deb692920... bitcoin-0.18.99-win64.zip
- b6486b438b75c3219d1c800d2c96a47f... bitcoin-0.18.99-x86_64-linux-gnu-debug.tar.gz
- cba2de75c02da6a2421514ccbc003f94... bitcoin-0.18.99-x86_64-linux-gnu.tar.gz
- 586e30720ea5eb8d041d959d1c9b1f6d... bitcoin-0.18.99.tar.gz
- 99aa33d388fb5e03e0616ebc9c56ea85... bitcoin-core-linux-0.19-res.yml
- edc5d01e4ae0c579112c34948938d466... bitcoin-core-osx-0.19-res.yml
- 3c9d5c92140315b84e728e8a48e7e767... bitcoin-core-win-0.19-res.yml
- b83614b692a6a26f9418144af4cc3095... linux-build.log
- 6b215962eaff1c9730f46265df4b0aac... osx-build.log
- eabfe80f5b20efd06c8dacac4c7309f8... win-build.log
Gitian builds for commit e513ff95a4399274fa94b53d9efb4ea4da7e72b7 (master and this pull):
- bb27885a6343b2bc6290df8ae8d2ac97... bitcoin-0.18.99-aarch64-linux-gnu-debug.tar.gz
- 58979a0cbf315394886632eaa5f74fa2... bitcoin-0.18.99-aarch64-linux-gnu.tar.gz
- 37f83fb49c74e823dc7df52a80cd582f... bitcoin-0.18.99-arm-linux-gnueabihf-debug.tar.gz
- 944e826cd337c651f3730f8aa21ee3fa... bitcoin-0.18.99-arm-linux-gnueabihf.tar.gz
- b4028fdc9955a9737539ea6ae7c5eda6... bitcoin-0.18.99-i686-pc-linux-gnu-debug.tar.gz
- 7cc5dd0c1fab31ce6404207e8ae606db... bitcoin-0.18.99-i686-pc-linux-gnu.tar.gz
- 747108ffd3556c43bd6ac8e883cff8dd... bitcoin-0.18.99-osx-unsigned.dmg
- ed53233126acb54f3ef479870015151e... bitcoin-0.18.99-osx64.tar.gz
- ca105130984e1614609eccec96107d61... bitcoin-0.18.99-riscv64-linux-gnu-debug.tar.gz
- 522715da914da7ca94f3bef493c840e5... bitcoin-0.18.99-riscv64-linux-gnu.tar.gz
- 37c6d8115519c3300742c207f29f0360... bitcoin-0.18.99-win64-debug.zip
- b33d381b30b7f97a180be3ec5dd59b44... bitcoin-0.18.99-win64-setup-unsigned.exe
- b52582dd90e8efbd4e009f416cc87640... bitcoin-0.18.99-win64.zip
- 5290f76b1552964084e153248abb4ff5... bitcoin-0.18.99-x86_64-linux-gnu-debug.tar.gz
- 17441686f7913fdea8a91d576d307e02... bitcoin-0.18.99-x86_64-linux-gnu.tar.gz
- 2ef116623a41bea8f6eb8e035a1e9307... bitcoin-0.18.99.tar.gz
- 0ac6c46e8d9c401dc0af434b6957cb06... bitcoin-core-linux-0.19-res.yml
- dce543fcab513fafbb39ae4a0879739f... bitcoin-core-linux-0.19-res.yml.diff
- 758396efc129b0118e99e022ca45d7c0... bitcoin-core-osx-0.19-res.yml
- 152ceca99d9c78f74b216abb5e4ea868... bitcoin-core-osx-0.19-res.yml.diff
- bc5855d1084f89f27b411eb72f47796d... bitcoin-core-win-0.19-res.yml
- 329ac902b924e283c932ee03e7650f2b... bitcoin-core-win-0.19-res.yml.diff
- db389de763935e147ad637bb1603d613... linux-build.log
- 63cf30633f7dfdd5fc8eddf94f4298c7... linux-build.log.diff
- 4a163a10d2a9b6962fcc69594e7acfbe... osx-build.log
- 0fe7c155befec20f6a5d7242b9900a97... osx-build.log.diff
- 648ea6f02f24e9c8ceaa176a532833ab... win-build.log
- a0a2b6b80ca082cb2086f5afe7d7d101... win-build.log.diff
DrahtBot removed the label Needs gitian build on Sep 6, 2019
fanquake requested review from theuni on Sep 8, 2019
laanwj commented at 3:13 pm on September 13, 2019: member

What is the advantage of this compared to the current way of passing options?
fanquake added the label Waiting for author on Sep 15, 2019
dongcarl commented at 4:07 pm on September 17, 2019: member

What is the advantage of this compared to the current way of passing options?

Our current way of passing options has the ./configure script check/use the native toolchain at configure time, and overrides that with the cross toolchain at make time (meaning checks performed at configure time were useless).

The new way checks/uses the correct cross toolchain at configure time, meaning we don’t need to override it at make time.
dongcarl removed the label Waiting for author on Sep 17, 2019
laanwj commented at 12:50 pm on September 18, 2019: member

The new way checks/uses the correct cross toolchain at configure time, meaning we don’t need to override it at make time.

Fair enough, that does sound better. Thanks.

ACK f0636d34185d235f51eebaa2ad14c1e6fcaed6c2
laanwj referenced this in commit 4b5e5ef4ce on Sep 18, 2019
laanwj merged this on Sep 18, 2019
laanwj closed this on Sep 18, 2019
sidhujag referenced this in commit b910bcf569 on Sep 23, 2019
deadalnix referenced this in commit f6efcad2d1 on Apr 3, 2020
ftrader referenced this in commit 81cd07a71e on Aug 17, 2020
PastaPastaPasta referenced this in commit 585d8ce44c on Jun 27, 2021
PastaPastaPasta referenced this in commit 225655a194 on Jun 28, 2021
PastaPastaPasta referenced this in commit 07f88085f4 on Jun 29, 2021
PastaPastaPasta referenced this in commit daeefff463 on Jul 1, 2021
PastaPastaPasta referenced this in commit 3e77f4144a on Jul 1, 2021
PastaPastaPasta referenced this in commit f5b1f99f65 on Jul 12, 2021
PastaPastaPasta referenced this in commit 821200cb2d on Jul 13, 2021
DrahtBot locked this on Dec 16, 2021

Contributors
dongcarl DrahtBot laanwj

Review Requested
theuni

Labels
Build system