depends: zlib: Move toolchain options to configure #16809

pull dongcarl wants to merge 1 commits into bitcoin:master from dongcarl:2019-09-improve-zlib-pkg changing 1 files +12 −9
  1. dongcarl commented at 6:39 PM on September 5, 2019: member 
    zlib has its own custom configure script, see comment in zlib.mk for
more details

    Performed Guix cross-builds locally and everything worked as expected.

  2. depends: zlib: Move toolchain options to configure
    zlib has its own custom configure script, see comment in zlib.mk for
more details
    f0636d3418
  3. dongcarl added the label Build system on Sep 5, 2019
  4. dongcarl added the label Needs gitian build on Sep 5, 2019
  5. DrahtBot commented at 8:09 PM on September 6, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 5e202382a987351a59d5cda98ea9f2aee99f61a5 (master):

    Gitian builds for commit e513ff95a4399274fa94b53d9efb4ea4da7e72b7 (master and this pull):

  6. DrahtBot removed the label Needs gitian build on Sep 6, 2019
  7. fanquake requested review from theuni on Sep 8, 2019
  8. laanwj commented at 3:13 PM on September 13, 2019: member

    What is the advantage of this compared to the current way of passing options?

  9. fanquake added the label Waiting for author on Sep 15, 2019
  10. dongcarl commented at 4:07 PM on September 17, 2019: member

    What is the advantage of this compared to the current way of passing options?

    Our current way of passing options has the ./configure script check/use the native toolchain at configure time, and overrides that with the cross toolchain at make time (meaning checks performed at configure time were useless).

    The new way checks/uses the correct cross toolchain at configure time, meaning we don't need to override it at make time.

  11. dongcarl removed the label Waiting for author on Sep 17, 2019
  12. laanwj commented at 12:50 PM on September 18, 2019: member

    The new way checks/uses the correct cross toolchain at configure time, meaning we don't need to override it at make time.

    Fair enough, that does sound better. Thanks.

    ACK f0636d34185d235f51eebaa2ad14c1e6fcaed6c2

  13. laanwj referenced this in commit 4b5e5ef4ce on Sep 18, 2019
  14. laanwj merged this on Sep 18, 2019
  15. laanwj closed this on Sep 18, 2019
  16. sidhujag referenced this in commit b910bcf569 on Sep 23, 2019
  17. deadalnix referenced this in commit f6efcad2d1 on Apr 3, 2020
  18. ftrader referenced this in commit 81cd07a71e on Aug 17, 2020
  19. PastaPastaPasta referenced this in commit 585d8ce44c on Jun 27, 2021
  20. PastaPastaPasta referenced this in commit 225655a194 on Jun 28, 2021
  21. PastaPastaPasta referenced this in commit 07f88085f4 on Jun 29, 2021
  22. PastaPastaPasta referenced this in commit daeefff463 on Jul 1, 2021
  23. PastaPastaPasta referenced this in commit 3e77f4144a on Jul 1, 2021
  24. PastaPastaPasta referenced this in commit f5b1f99f65 on Jul 12, 2021
  25. PastaPastaPasta referenced this in commit 821200cb2d on Jul 13, 2021
  26. DrahtBot locked this on Dec 16, 2021
Contributors
dongcarlDrahtBotlaanwj


theuni

Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-01 03:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me