refactor: wallet: Cleanup walletinitinterface.h #16830

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20190908-cleanup-walletinitinterface changing 1 files +0 −4

hebasto commented at 2:52 PM on September 8, 2019: member

Forward declarations of CScheduler and CRPCTable classes are no longer needed after ea961c3d7256c66146b4976ab1293db4a628c0de (#14437) commit.

Including <string> is no longer needed after 4d4185a4f0e40c033a587871839a47cb3f89ee93 (#13190) commit.

refactor: Cleanup walletinitinterface.h

Forward declarations of CScheduler and CRPCTable classes are no longer 
needed after ea961c3d7256c66146b4976ab1293db4a628c0de commit.
Including <string> is no longer needed after 
4d4185a4f0e40c033a587871839a47cb3f89ee93 commit.

4be3b7680e

fanquake added the label Wallet on Sep 8, 2019
fanquake added the label Refactoring on Sep 8, 2019
theStack commented at 5:15 PM on September 8, 2019: member

ACK 4be3b76 LGTM
DrahtBot commented at 5:43 PM on September 8, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16659 (refactoring: Remove unused includes by practicalswift)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
kristapsk approved
kristapsk commented at 6:07 PM on September 8, 2019: contributor

ACK 4be3b7680e6324294d9241232a6f1eae36c85a9e (tested that it builds)
promag commented at 9:17 PM on September 8, 2019: member

ACK 4be3b7680e6324294d9241232a6f1eae36c85a9e.
meshcollider referenced this in commit 91fcb9ff66 on Sep 8, 2019
meshcollider merged this on Sep 8, 2019
meshcollider closed this on Sep 8, 2019
hebasto deleted the branch on Sep 9, 2019
deadalnix referenced this in commit aa7cbc34a2 on May 13, 2020
ftrader referenced this in commit 85fea76aa7 on Aug 17, 2020
PastaPastaPasta referenced this in commit 8677f45007 on Nov 1, 2021
PastaPastaPasta referenced this in commit d33c4791f8 on Nov 3, 2021
pravblockc referenced this in commit d8a0855b64 on Nov 18, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#13190 Have gArgs handle printing help #14437 Refactor: Start to separate wallet from node

refactor: wallet: Cleanup walletinitinterface.h #16830

Conflicts