Recent questions have come up regarding dynamic service registration
(see #16442 (review)
and the assumeutxo project which needs to dynamically flip NODE_NETWORK).
While investigating how dynamic service registration might work, I was confused about how we convey local services to peers. This adds some documentation that hopefully clarifies this process.
Could you format the comments in a Doxygen-friendly way?
To my knowledge, these are already formatted for Doxygen… both /** ... */ and //! are recognized, and the class/method references should autolink properly.
Recent questions have come up regarding dynamic service registration
(see https://github.com/bitcoin/bitcoin/pull/16442#discussion_r308702676
and the assumeutxo project, which needs to dynamically flip NODE_NETWORK).
While investigating how dynamic service registration might work, I was
confused about how we convey local services to peers. This adds some
documentation that hopefully clarifies this process.
797@@ -786,8 +798,12 @@ class CNode
798 private:
799 const NodeId id;
800 const uint64_t nLocalHostNonce;
801- // Services offered to this peer
802+
803+ //! Services offered to this peer.
804+ //! This is supplied by the parent CConman during peer connection
805+ //! (CConman::ConectNode()) from its attribute of the same name.
const, i.e. impossible to change after the connection. And maybe also how this interacts with IBD or background indexes that are turned on when the chain is already synced.
Thanks for the reviews. Have fleshed out some explanatory doc around why local services don’t change and have fixed the Doxygen autolinking.
