This changes the type of the entry time of txs into the mempool from int64_t to std::chrono::seconds.
The benefits:
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
ConceptACK
I think LimitMemPoolSize() should have std::chrono::seconds age instead of unsigned long age, which means you can just pass in std::chrono::hours{gArgs.GetArg(...)}; makes it a bit tidier.
Having int64_t as_seconds(std::chrono::seconds t) { return t.count(); } seems like it would be better than using int64_t{xxx.count()} fwiw; that way if we change xxx’s type either the conversion happens automatically if there’s no loss of precision, or you get a compile time error.
Also, remove the now unused "Mine a single block to get out of IBD".
This was fixed in commit 1111aecbb5.
417@@ -418,7 +418,7 @@ static void entryToJSON(const CTxMemPool& pool, UniValue& info, const CTxMemPool
418 info.pushKV("weight", (int)e.GetTxWeight());
419 info.pushKV("fee", ValueFromAmount(e.GetFee()));
420 info.pushKV("modifiedfee", ValueFromAmount(e.GetModifiedFee()));
421- info.pushKV("time", e.GetTime());
422+ info.pushKV("time", int64_t{count_seconds(e.GetTime())});
int64_t{} here?
1540@@ -1541,11 +1541,11 @@ void static ProcessGetData(CNode* pfrom, const CChainParams& chainparams, CConnm
1541 if (mi != mapRelay.end()) {
1542 connman->PushMessage(pfrom, msgMaker.Make(nSendFlags, NetMsgType::TX, *mi->second));
1543 push = true;
1544- } else if (pfrom->m_tx_relay->timeLastMempoolReq) {
1545+ } else if (pfrom->m_tx_relay->m_last_mempool_req.load().count()) {
count_seconds here, if it is preferred to inline .count() (according to the comment)?
optional here some day instead of a magic value, but no need to do that here.
std::chrono::duration::zero value here? I found count() to be unintuitive when I was looking at related code just now (but this std::chrono stuff is new to me so I’m still figuring out how to use it).
Comparing it to zero would also work, but still be odd, as the code is written as if the member were an optional.
I think we can just stop treating it as optional (always assume the last mempool request time for peers was in year 1970). But that can be done in a follow up pull request.