test: follow-up to rpc: default maxfeerate value as BTC/kB #16929

1. 
   jonatack commented at 2:18 pm on September 21, 2019: member

   Follow-up to PR #16521.

   • Fix incorrect value in rpc_rawtransaction test as per https://github.com/bitcoin/bitcoin/pull/16521/files#r325842308
   • Improve the code docs
   • Use named arguments as per https://github.com/bitcoin/bitcoin/pull/16521/files#r310715127

   Happy to squash or keep only the first commit if the others are too fixup-y.

2. test: fix incorrect value in rpc_rawtransaction.py acc14c5093
3. doc: improve rawtransaction code/test docs 5c1cd78b7e
4. fanquake added the label Tests on Sep 21, 2019
5. in test/functional/feature_segwit.py:244 in 411391463e outdated

   240@@ -241,7 +241,7 @@ def run_test(self):
   241         tx.vin.append(CTxIn(COutPoint(int(txid1, 16), 0), b''))
   242         tx.vout.append(CTxOut(int(49.99 * COIN), CScript([OP_TRUE, OP_DROP] * 15 + [OP_TRUE])))
   243         tx2_hex = self.nodes[0].signrawtransactionwithwallet(ToHex(tx))['hex']
   244-        txid2 = self.nodes[0].sendrawtransaction(tx2_hex)
   245+        txid2 = self.nodes[0].sendrawtransaction(hexstring=tx2_hex)
   

   ---

   ---

   

   promag commented at 9:25 am on September 22, 2019:

   411391463ed9de5076f419f6451150dffea7225b

   Could use named parameters only when maxfeerate= so these could be reverted.

   ---

   

   jonatack commented at 10:29 am on September 22, 2019:

   Thanks for reviewing! True, done.
6. 
   promag commented at 9:28 am on September 22, 2019: member

   ACK 411391463ed9de5076f419f6451150dffea7225b.
7. test: use named args for sendrawtransaction calls

   involving more than one argument.

   6659810e2f
8. jonatack force-pushed on Sep 22, 2019
9. 
   laanwj commented at 9:51 am on September 25, 2019: member

   ACK 6659810e2f38994813aa9d7644d570ae0152fa2c
10. laanwj referenced this in commit 742cd77f6f on Sep 25, 2019
11. laanwj merged this on Sep 25, 2019
12. laanwj closed this on Sep 25, 2019

    ---

13. jonatack deleted the branch on Sep 25, 2019
14. sidhujag referenced this in commit a16705aba6 on Sep 25, 2019
15. jasonbcox referenced this in commit 005230930f on Oct 22, 2020
16. MarcoFalke locked this on Dec 16, 2021

Contributors
jonatack promag laanwj

Labels
Tests