In -loadblock mode, ProcessBlock() is called without node to retrieve parents from, if needed. In this case, prefer to not store orphans as all, as they would just linger in RAM.
Do not accept orphan blocks in -loadblock mode #1695
pull sipa wants to merge 1 commits into bitcoin:master from sipa:noloadorphan changing 1 files +9 −6-
sipa commented at 5:20 PM on August 21, 2012: member
-
Do not accept orphan blocks in -loadblock mode 5c88e3c108
-
Diapolo commented at 5:51 PM on August 21, 2012: none
Does this cleanup orphan blocks stored in our block-files when re-importing them as new block-files?
-
gavinandresen commented at 5:54 PM on August 21, 2012: contributor
ACK
-
sipa commented at 6:09 PM on August 21, 2012: member
@Diapolo Normally, block files do not contain orphan blocks (by which i mean blocks that have no known parent), they do have chains of stale chains that got reorganised away (which is what I assume you're talking about). This only prevents real orphan blocks from being imported.
-
jgarzik commented at 8:12 PM on August 21, 2012: contributor
ACK
-
BitcoinPullTester commented at 12:11 AM on August 22, 2012: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5c88e3c108f8bbe0edbcd88b3f48e3eaf611cd7c for binaries and test log.
- sipa referenced this in commit 1a3dcca8f4 on Aug 22, 2012
- sipa merged this on Aug 22, 2012
- sipa closed this on Aug 22, 2012
- suprnurd referenced this in commit 788ae63ac2 on Dec 5, 2017
- suprnurd referenced this in commit 8591448094 on Dec 5, 2017
- owlhooter referenced this in commit d6e2aa843c on Oct 10, 2018
- DrahtBot locked this on Sep 8, 2021
Contributors